Skip to content

webui: fix for PHP < 7.3#2067

Merged
arogge merged 4 commits intobareos:masterfrom
joergsteffens:dev/joergs/webui-restore-fix
Dec 16, 2024
Merged

webui: fix for PHP < 7.3#2067
arogge merged 4 commits intobareos:masterfrom
joergsteffens:dev/joergs/webui-restore-fix

Conversation

@joergsteffens
Copy link
Member

@joergsteffens joergsteffens commented Dec 15, 2024

The Bareos WebUI uses a function, only available in PHP >= 7.3, while EL8 ships with PHP 7.2.
This PR rewrite the code to circumvent this, making the restore dialog work again.
Also it cleans up the code to prevent a PHP Notice.

Please check

  • Short description and the purpose of this PR is present above this paragraph
  • Your name is present in the AUTHORS file (optional)

If you have any questions or problems, please give a comment in the PR.

Helpful documentation and best practices

Checklist for the reviewer of the PR (will be processed by the Bareos team)

Make sure you check/merge the PR using devtools/pr-tool to have some simple automated checks run and a proper changelog record added.

General
  • Is the PR title usable as CHANGELOG entry?
  • Purpose of the PR is understood
  • Commit descriptions are understandable and well formatted
  • Required backport PRs have been created
  • Correct milestone is set
Source code quality
  • Source code changes are understandable
  • Variable and function names are meaningful
  • Code comments are correct (logically and spelling)
  • Required documentation changes are present and part of the PR

@joergsteffens joergsteffens added this to the 24.0.1 milestone Dec 15, 2024
@joergsteffens joergsteffens added bugfix bug This addresses a bug requires no backport This will not be backported requires backport to 24 and removed requires no backport This will not be backported labels Dec 15, 2024
@sebsura sebsura modified the milestones: 24.0.1, 25.0.0 Dec 16, 2024
@joergsteffens joergsteffens force-pushed the dev/joergs/webui-restore-fix branch from b31a2a5 to 0b1c6e7 Compare December 16, 2024 09:38
@joergsteffens joergsteffens mentioned this pull request Dec 16, 2024
7 tasks
The fileset index does not exist and is not used.
Removing this line prevent a PHP Notice.
@arogge arogge force-pushed the dev/joergs/webui-restore-fix branch from 0b1c6e7 to 25ce3a0 Compare December 16, 2024 13:00
@arogge arogge merged commit 9f422a6 into bareos:master Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug This addresses a bug requires backport to 24

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants