Skip to content

filed: detect integer overflow during backup#2024

Merged
BareosBot merged 7 commits intobareos:bareos-23from
pstorz:backport/bareos-23/detect_fileindex_overflow
Nov 28, 2024
Merged

filed: detect integer overflow during backup#2024
BareosBot merged 7 commits intobareos:bareos-23from
pstorz:backport/bareos-23/detect_fileindex_overflow

Conversation

@pstorz
Copy link
Member

@pstorz pstorz commented Nov 19, 2024 •
edited by sebsura
Loading

Changes from original PR:

  • Backported support for test-local environment as this is needed for the test
  • Backported if() guard for file-autochanger test

Backport of PR #1952 to bareos-23

Checklist for the reviewer of the PR (will be processed by the Bareos team)

Make sure you check/merge the PR using devtools/pr-tool to have some simple automated checks run and a proper changelog record added.

General
  • Correct milestone is set
Source code quality (if there were changes to the original PR)
  • Source code changes are understandable
  • Variable and function names are meaningful
  • Code comments are correct (logically and spelling)
  • Required documentation changes are present and part of the PR

Backport quality

@pstorz pstorz mentioned this pull request Nov 19, 2024
Merged
15 tasks
@sebsura sebsura added this to the 23.1.1 milestone Nov 21, 2024
sebsura
sebsura requested changes Nov 21, 2024
View reviewed changes
@sebsura sebsura force-pushed the backport/bareos-23/detect_fileindex_overflow branch from 9a70054 to 64108c5 Compare November 27, 2024 06:10
@sebsura sebsura self-assigned this Nov 27, 2024
@sebsura sebsura force-pushed the backport/bareos-23/detect_fileindex_overflow branch 2 times, most recently from e7b4474 to 65b59fc Compare November 28, 2024 09:25
pstorz and others added 7 commits November 28, 2024 10:36
@pstorz @BareosBot
backup.cc: detect overflow
34bae1d 
(cherry picked from commit 968fcf6)
@pstorz @BareosBot
build bareos-test-fd
9014970 
(cherry picked from commit 80da7d0)
@pstorz @BareosBot
cmake: build test fd with file limit enabled
dad05cf 
(cherry picked from commit d8f76f8)
@sebsura @BareosBot
backup: fix deadlocking while trying to write jmsg
7c1c568 
Jmsg may try to take the jcr->mutex_guard() lock, so we cannot call it
while having the lock held.

(cherry picked from commit ae850a4)
@sebsura @BareosBot
systemtests: add test for fileindex overflow detection
e5a5cfb 
(cherry picked from commit 4ea7387)
@sebsura @BareosBot
environment: add support for test local environment
b9e8143
@BareosBot
Update CHANGELOG.md
0bfdc7b
@BareosBot BareosBot force-pushed the backport/bareos-23/detect_fileindex_overflow branch from 71f7b8d to 0bfdc7b Compare November 28, 2024 10:37
@BareosBot BareosBot merged commit 61863b5 into bareos:bareos-23 Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sebsura sebsura sebsura approved these changes

Assignees

@sebsura sebsura

Labels

is a backport to 23

Projects

None yet

Milestone

23.1.1

Development

Successfully merging this pull request may close these issues.

3 participants

@pstorz @sebsura @BareosBot