filed: detect integer overflow during backup#1952
Merged
BareosBot merged 7 commits intobareos:masterfrom Nov 19, 2024
Merged
Conversation
f19534d to
cfefb11
Compare
sebsura
requested changes
Sep 12, 2024
sebsura
requested changes
Sep 25, 2024
Contributor
sebsura
left a comment
There was a problem hiding this comment.
We should probably add checks to ::SendBaseFileList and ::SendDeletedList; either they should check for the return value of EncodeAndSendAttributes or they should check if the job was canceled and stop.
Maybe even both.
d77891e to
968fcf6
Compare
sebsura
requested changes
Nov 8, 2024
33fa3fc to
008560c
Compare
sebsura
requested changes
Nov 18, 2024
sebsura
approved these changes
Nov 18, 2024
d75f307 to
4ea7387
Compare
7 tasks
Jmsg may try to take the jcr->mutex_guard() lock, so we cannot call it while having the lock held.
dd67859 to
680cb33
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The filedaemon now makes sure that the fileindex does not overflow during the backup. The upper limit for file indices is currently 2^(31) - 1, but we now also build a test file daemon that has this limit set to 20, so that we can actually test the overflow detection.
Thank you for contributing to the Bareos Project!
Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
Make sure you check/merge the PR using
devtools/pr-toolto have some simple automated checks run and a proper changelog record added.General
Source code quality
Tests