Skip to content

Fixes #240: Optimizing systemd service files#2

Closed
tigerfoot wants to merge 2 commits intobareos:masterfrom
tigerfoot:master
Closed

Fixes #240: Optimizing systemd service files#2
tigerfoot wants to merge 2 commits intobareos:masterfrom
tigerfoot:master

Conversation

@tigerfoot
Copy link
Contributor

Find a revision of the systemd service files
Added documentation line for each service
Added Restart on-failure
For bareos-dir
Added soft dependency for postgresql & mysql
(doesn't fail if postgresql or mysql is not present like for remote db) it just indicate clearly to systemd that we want to start after them if exist

 Added soft dependency for  postgresql & mysql
 Added Restart on-failure
@mvwieringen
Copy link
Contributor

Please add a bug entry in Mantis and then update your commit message to read something like

Fixes #xxx: short mantis description

Then we have the full process including the linkage by Mantis to the source commit.

Suppress warnings in syslog [/usr/lib/systemd/system/bareos-dir.service:16] Unknown lvalue 'Alias' in section 'Unit'. Ignoring.
@tigerfoot
Copy link
Contributor Author

Fixes #240: improve systemd unit files

https://bugs.bareos.org/view.php?id=240

@tigerfoot
Copy link
Contributor Author

Just another comment, take care of travis test it ran a build with Ubuntu/Linaro 4.6.3-1ubuntu5 which is known to not have --with-systemd !

@mvwieringen
Copy link
Contributor

Almost ok, I should have said make your commit message look something like
(this is a commit from a bugfix I did a couple of weeks back.):

When using multiple catalogs always the first is chosen.

With the introduction of the autoselection of the right catalog when
none is selected we also auto select a catalog in the pool resource.
That is of course wrong as that means every pool always has an
explicit override of the catalog to use to the first catalog which
makes the override in the client useless.

Fixes #229: When using multiple catalogs always the first is chosen.

e.g.

short description from Mantis, then your whole story what you fixed and then the Fixes line.

Further more as the second fix is more or less a fixup of the first you should merge it into one.

e.g. if you are on a branch (hope you started one in your own git repo) you can use
"git rebase -i master" and then change the second patch to read "fixup ..."
if you then set the first to read "reword ..." you can both merge the second into
the first and put in the new commit message.

@mvwieringen
Copy link
Contributor

What travis does is up to them its nice that they provide the service not much you can demand from them.
So lets presume you tested your patch on some systemd enabled systems.

@tigerfoot
Copy link
Contributor Author

Fortunately yes, was what I changed manually on each setup. Now being too lazy :-)

@tigerfoot tigerfoot closed this Oct 25, 2013
dne pushed a commit to dne/bareos that referenced this pull request May 8, 2018
pstorz pushed a commit that referenced this pull request Feb 4, 2020
Use a sub-DB for DUPSORT item #1/#2 per key if needed: Not a sub-
page too big for a node, nor an overflow page (which not all DUPSORT
code checks for). Move "insert" code, to avoid non-loop goto upwards.

(This is the commit which needs the change to xdata.mv_size in
commit 9d6e4a9 "page sizes".)
franku pushed a commit that referenced this pull request Jul 3, 2020
This time, define entirely new dpl_* macros rather than try to override
existing macros from <check.h>
franku pushed a commit that referenced this pull request Jul 3, 2020
This re-implements commit 2de55b5
using the new dpl_assert*() macros instead of using macros which
were fixed re-definitions of macros in <check.h>
franku pushed a commit that referenced this pull request Feb 25, 2021
Initial copy of mysql plugin from bareos git repository into new contrib repo
franku pushed a commit that referenced this pull request Feb 25, 2021
joergsteffens added a commit that referenced this pull request Feb 13, 2023
Make bareos-fuse be installable via pip. Adapt for Python 3.
sebsura added a commit to sebsura/bareos that referenced this pull request Jul 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants