debian: fix dedupable backend names#1978
Merged
BareosBot merged 11 commits intobareos:bareos-23from Oct 22, 2024
Merged
Conversation
074481e to
6a1a99b
Compare
17 tasks
bruno-at-bareos
approved these changes
Oct 15, 2024
Contributor
bruno-at-bareos
left a comment
There was a problem hiding this comment.
Review and testing done. Nice work!
bd531b5 to
d5d70bf
Compare
bruno-at-bareos
requested changes
Oct 22, 2024
Contributor
bruno-at-bareos
left a comment
There was a problem hiding this comment.
Can we recheck if we really want to have jit on by default on 23?
core/src/stored/stored_conf.cc
Outdated
| CFG_ITEM_DEFAULT | CFG_ITEM_PLATFORM_SPECIFIC, PATH_BAREOS_BACKENDDIR, NULL, NULL}, | ||
| #endif | ||
| {"JustInTimeReservation", CFG_TYPE_BOOL, ITEM(res_store, just_in_time_reservation), 0, CFG_ITEM_DEFAULT, "No", "24.0.0-", | ||
| {"JustInTimeReservation", CFG_TYPE_BOOL, ITEM(res_store, just_in_time_reservation), 0, CFG_ITEM_DEFAULT, "Yes", "23.1.0-", |
Contributor
There was a problem hiding this comment.
I have a doubt for 23.1.0 that we want to change the default behavior of the release.
With 23.1.x we normally introduce a new technical feature jit in that case, but we certainly don't want to change the default, even if we know how good it can be and increase the global performance. This may be discussed around with the other devs.
Suggested change
| {"JustInTimeReservation", CFG_TYPE_BOOL, ITEM(res_store, just_in_time_reservation), 0, CFG_ITEM_DEFAULT, "Yes", "23.1.0-", | |
| {"JustInTimeReservation", CFG_TYPE_BOOL, ITEM(res_store, just_in_time_reservation), 0, CFG_ITEM_DEFAULT, "No", "23.1.0-", |
This is certainly a missed from previous submission.
Contributor
There was a problem hiding this comment.
So I cleaned it up.
(cherry picked from commit 8700e9b)
(cherry picked from commit 6a629f8)
(cherry picked from commit f87e809)
(cherry picked from commit 137bcfd)
(cherry picked from commit 1dee6bb)
(cherry picked from commit ab42273)
(cherry picked from commit f1ad716)
The reservation related tests cannot run with jit reservation as they try to check for an actual reservation which may not have taken place yet; or was announced differently. Either way the test will fail with jit reservation = Yes, so we need to explicitly disable it as it is the default now. (cherry picked from commit c452263)
(cherry picked from commit 076c83f)
add `--no-psqlrc` to `psql` call Signed-off-by: Bruno Friedmann <bruno.friedmann@bareos.com> (cherry picked from commit a24c136)
d5d70bf to
66e5536
Compare
bruno-at-bareos
approved these changes
Oct 22, 2024
Contributor
bruno-at-bareos
left a comment
There was a problem hiding this comment.
Final review, here we go green for merge.
Thx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of PR #1977 to bareos-23
Differences:
Checklist for the reviewer of the PR (will be processed by the Bareos team)
Make sure you check/merge the PR using
devtools/pr-toolto have some simple automated checks run and a proper changelog record added.General
Source code quality (if there were changes to the original PR)
Backport quality