Skip to content

debian: fix dedupable backend names#1977

Merged
BareosBot merged 12 commits intobareos:masterfrom
sebsura:dev/ssura/master/fix-dedupable-renaming
Oct 22, 2024
Merged

debian: fix dedupable backend names#1977
BareosBot merged 12 commits intobareos:masterfrom
sebsura:dev/ssura/master/fix-dedupable-renaming

Conversation

@sebsura
Copy link
Contributor

@sebsura sebsura commented Oct 9, 2024 •
edited by bruno-at-bareos
Loading

This PR also enhances the dedup documentation a bit and changes the default of justintime reservation to yes.

Thank you for contributing to the Bareos Project!

Please check

  • Short description and the purpose of this PR is present above this paragraph
  • Your name is present in the AUTHORS file (optional)

If you have any questions or problems, please give a comment in the PR.

Helpful documentation and best practices

Checklist for the reviewer of the PR (will be processed by the Bareos team)

Make sure you check/merge the PR using devtools/pr-tool to have some simple automated checks run and a proper changelog record added.

General
  • Is the PR title usable as CHANGELOG entry?
  • Purpose of the PR is understood
  • Commit descriptions are understandable and well formatted
  • Required backport PRs have been created
  • Correct milestone is set
Source code quality
  • Source code changes are understandable
  • Variable and function names are meaningful
  • Code comments are correct (logically and spelling)
  • Required documentation changes are present and part of the PR
Tests
  • Decision taken that a test is required (if not, then remove this paragraph)
  • The choice of the type of test (unit test or systemtest) is reasonable
  • Testname matches exactly what is being tested
  • On a fail, output of the test leads quickly to the origin of the fault

@sebsura sebsura mentioned this pull request Oct 9, 2024
Merged
7 tasks
@sebsura sebsura added this to the 24.0.0 milestone Oct 9, 2024
@sebsura sebsura self-assigned this Oct 9, 2024
@sebsura sebsura force-pushed the dev/ssura/master/fix-dedupable-renaming branch from a6673d5 to f445fd1 Compare October 9, 2024 08:22
@arogge arogge mentioned this pull request Oct 11, 2024
Merged
17 tasks
bruno-at-bareos
bruno-at-bareos requested changes Oct 15, 2024
View reviewed changes
Copy link
Contributor

@bruno-at-bareos bruno-at-bareos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!!!

During review I would really appreciate if we can have an explicit comment explaining why we change the default configuration and force Just In Time Reservation = No

On the other side as reveal during test, we need to recheck why unaligned.data is not fully truncated after a truncate command.
Like in systemtest check that size of just labeled volume = truncated one?

@sebsura sebsura force-pushed the dev/ssura/master/fix-dedupable-renaming branch 2 times, most recently from bc95fa0 to a9363a2 Compare October 17, 2024 10:50
@sebsura sebsura force-pushed the dev/ssura/master/fix-dedupable-renaming branch from a9363a2 to 95261f8 Compare October 17, 2024 11:14
@bruno-at-bareos
Copy link
Contributor

bruno-at-bareos commented Oct 17, 2024

@sebsura it look like you have missed the dedup-conf packaging part ;-)

@sebsura
Copy link
Contributor Author

sebsura commented Oct 18, 2024

Im not sure if we want to package it (thats also why i did not prefix it with b). Its mostly just an internal debugging tool. Maybe we can talk about this next week on what you think is best.

@sebsura sebsura force-pushed the dev/ssura/master/fix-dedupable-renaming branch from 7f43289 to a24c136 Compare October 22, 2024 07:31
bruno-at-bareos
bruno-at-bareos approved these changes Oct 22, 2024
View reviewed changes
Copy link
Contributor

@bruno-at-bareos bruno-at-bareos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for those great fixes & enhancements.

sebsura and others added 12 commits October 22, 2024 13:45
@sebsura @BareosBot
debian-control: fix not renaming DEDUP into DEDUPABLE
c0eb523
@sebsura @BareosBot
docs: add example configuration and fix since-version
33bb266
@sebsura @BareosBot
docs: add missing doc file and fix typos
01731f5
@sebsura @BareosBot
docs: add some dedupable developer documentaton
315c639
@sebsura @BareosBot
fvec: fix comment
b4ea6ba
@sebsura @BareosBot
dedup-example: add archive device
2799f6a
@sebsura @BareosBot
tools: add dedup-conf tool to better read dedup configs
6a05a21
@sebsura @BareosBot
stored-conf: change jit reservation default value to yes
993c63a
@sebsura @BareosBot
tests: fix reservation tests by disabling jit reservation
242f762 
The reservation related tests cannot run with jit reservation as they
try to check for an actual reservation which may not have taken place
yet; or was announced differently.

Either way the test will fail with jit reservation = Yes, so we need
to explicitly disable it as it is the default now.
@sebsura @BareosBot
stored: restrict jit reservation to native jobs
8f04338
@bruno-at-bareos @BareosBot
systemtests: improve reliability with --no-psqlrc
eeef30d 
add `--no-psqlrc` to `psql` call

Signed-off-by: Bruno Friedmann <bruno.friedmann@bareos.com>
@BareosBot
Update CHANGELOG.md
0a58213
@BareosBot BareosBot force-pushed the dev/ssura/master/fix-dedupable-renaming branch from dfdeecd to 0a58213 Compare October 22, 2024 13:45
@BareosBot BareosBot merged commit 76f5e49 into bareos:master Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bruno-at-bareos bruno-at-bareos bruno-at-bareos approved these changes

Assignees

@sebsura sebsura

Labels

requires backport to 23

Projects

None yet

Milestone

24.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@sebsura @bruno-at-bareos @BareosBot