Fix missing DLL in windows packaging#1807
Merged
BareosBot merged 4 commits intobareos:masterfrom May 17, 2024
Merged
Conversation
Member
Author
|
I addresses your remarks, I hope all is good now. |
5492dc8 to
113301c
Compare
This was referenced May 15, 2024
replace /nonfatal file copies by conditional fatal ones this makes sure don't accidentially skip files we wanted. It also makes sure we don't like files that don't exist anymore.
remove unused label
113301c to
dd6965c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After switching to a newer crossbuild-image a DLL for bareos-tray-monitor.exe is missing from packaging. This PR adds that DLL and fixes some minor issues with the NSI script.
This will resolve #1801
Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
Make sure you check/merge the PR using
devtools/pr-toolto have some simple automated checks run and a proper changelog record added.General
Source code quality