Skip to content

infra : GitHub community addition#1755

Merged
arogge merged 3 commits intobareos:masterfrom
bruno-at-bareos:dev/bruno/master/github-community
Apr 19, 2024
Merged

infra : GitHub community addition#1755
arogge merged 3 commits intobareos:masterfrom
bruno-at-bareos:dev/bruno/master/github-community

Conversation

@bruno-at-bareos
Copy link
Contributor

@bruno-at-bareos bruno-at-bareos commented Mar 28, 2024

this PR aims to improve github community scoring by adding a root license.md file, also a contributing.md guide and a code of conduct.

There's no needs for building, nor for backport.
We may want to test the commit on bareos-testing before merging.

OP#5754

Please check

  • Short description and the purpose of this PR is present above this paragraph
  • Your name is present in the AUTHORS file (optional)

If you have any questions or problems, please give a comment in the PR.

Helpful documentation and best practices

@bruno-at-bareos bruno-at-bareos added nobuild documentation This PR changes only documentation labels Mar 28, 2024
Copy link
Member

@arogge arogge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a few comments on the CoC and suggestions for relocating contributor and license information.

CONTRIBUTING.md Outdated

If you want to contribute something to this repo please read our contribution policy at

https://www.bareos.org/en/howto-contribute.html
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that does not (yet) link to something reasonable.
Maybe we want to migrate the contributor section from the docs into MD format and place it here.
We could still include it in the docs with the same mechanism that use for the CHANGELOG.md

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok then we need input from owner how they want to handle this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Decision was made during DevMeeting to keep it like it is actually and web page will soon updated

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still you should update the link to https://www.bareos.com/community/ ,which is the redirection target of the above link.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still you should update the link to https://www.bareos.com/community/ ,which is the redirection target of the above link.

Thanks I missed that redirection :-)

@bruno-at-bareos
Copy link
Contributor Author

bruno-at-bareos commented Apr 9, 2024

About /LICENSE.txt this will be build in PR #1753

@bruno-at-bareos bruno-at-bareos force-pushed the dev/bruno/master/github-community branch from a0b488a to ad23fdd Compare April 10, 2024 14:45
Signed-off-by: Bruno Friedmann <bruno.friedmann@bareos.com>
Signed-off-by: Bruno Friedmann <bruno.friedmann@bareos.com>

fix terminology
Signed-off-by: Bruno Friedmann <bruno.friedmann@bareos.com>
@bruno-at-bareos bruno-at-bareos force-pushed the dev/bruno/master/github-community branch from ad23fdd to f1f023c Compare April 10, 2024 14:55
Copy link
Member

@arogge arogge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Sorry for taking that long to review this.

@arogge arogge merged commit b0c56a0 into bareos:master Apr 19, 2024
@bruno-at-bareos bruno-at-bareos deleted the dev/bruno/master/github-community branch November 25, 2024 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation This PR changes only documentation nobuild

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants