Generate LICENSE.txt from LICENSE.template#1753
Merged
BareosBot merged 8 commits intobareos:masterfrom Apr 15, 2024
Merged
Conversation
bruno-at-bareos
requested changes
Apr 8, 2024
Contributor
bruno-at-bareos
left a comment
There was a problem hiding this comment.
Nice work.
- There's a fix for ./core/src/win32/plugins/filed/mssqlvdi-fd.cc instead of .c
- A control to see why it would be mandatory to have it included in exception as it is AGPL.
- We need to decide if we want this as LICENSE.txt in github root folder and then use that one for packaging.
d37c970 to
ba432de
Compare
2 tasks
Contributor
|
We may want to sort out the building of LICENSE.txt in root related to #1755 |
Contributor
|
As discussed during the meeting, we would like to have this Makefile able to build /LICENSE.txt file |
Contributor
bruno-at-bareos
left a comment
There was a problem hiding this comment.
While it is ok now, could you handle the /LICENSE.txt generation?
Member
Author
|
As discussed in the DevMeeting, I'll do a rework and create the LICENSE.txt file. |
183fda8 to
13e21fa
Compare
bruno-at-bareos
requested changes
Apr 11, 2024
Contributor
bruno-at-bareos
left a comment
There was a problem hiding this comment.
Nice work, we're almost done.
Please check my comments.
bruno-at-bareos
requested changes
Apr 15, 2024
Contributor
bruno-at-bareos
left a comment
There was a problem hiding this comment.
With the removal of the cmake target, the README.md in third party need to be fixed. See suggestion.
bruno-at-bareos
approved these changes
Apr 15, 2024
Contributor
bruno-at-bareos
left a comment
There was a problem hiding this comment.
Thanks nice improvement.
9930fd0 to
535874d
Compare
Fix adding webui/copyright, remove unimportant sections, update to 2024.
Create LICENSE.txt by calling devtools/update-license-file.sh which merges LICENSE.template and core/LICENSE. core/LICENSE covers the code in core/ and stays unchanged, at it has been setup with legal help. Before there has been a mechanism to update debian/copyright. Now debian/copyright is just a link to LICENSE.txt, which is formated according to https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/ Co-authored-by: Bruno Friedmann @bareos <89836284+bruno-at-bareos@users.noreply.github.com>
... as this third-party library is alredy covered in LICENSE.txt
by calling: devtools/update-license-file.sh
Moved file from core/cmake to cmake, as it is not specific for core.
Signed-off-by: Bruno Friedmann <bruno.friedmann@bareos.com>
3385f86 to
cf0a2ee
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moved away from generating
debian/copyrightand createLICENSE.txtinstead.Fix adding
webui/copyright, remove unimportant sections, update to 2024.Thank you for contributing to the Bareos Project!
Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
Make sure you check/merge the PR using
devtools/pr-toolto have some simple automated checks run and a proper changelog record added.General
Source code quality