cats: fixes BigSqlQuery header fetching#1746
Merged
Conversation
sebsura
requested changes
Mar 27, 2024
Contributor
sebsura
left a comment
There was a problem hiding this comment.
Great work! I requested some changes below. I think we can also easily add a test for this.
Having the tmp/file-list contain tmp/data twice is enough to get over the 100 file mark. Afterwards we can check if a list files outputs the correct headers.
fd4431f to
bb0d3cf
Compare
sebsura
requested changes
Mar 27, 2024
Contributor
sebsura
left a comment
There was a problem hiding this comment.
I added some feedback to your test.
sebsura
approved these changes
Mar 27, 2024
Contributor
sebsura
left a comment
There was a problem hiding this comment.
Thanks for your work. I added some comments. Feel free to ignore them.
f3cef00 to
e1ad238
Compare
This was referenced Mar 27, 2024
BigSqlQuery fetches data in 100 row chunks. This change makes sure, that subsequent chunks also have valid header information. Fixes: #1007: JSON API: 'list files' returns malformed json Co-authored-by: Sebastian Sura <124262655+sebsura@users.noreply.github.com>
Co-authored-by: Sebastian Sura <124262655+sebsura@users.noreply.github.com>
b70535b to
3888a86
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BigSqlQuery fetches data in 100 row chunks.
This change makes sure, that subsequent chunks
also have valid header information.
Fixes: https://bugs.bareos.org/view.php?id=1007 JSON API: 'list files' returns malformed json
OP#5753
Thank you for contributing to the Bareos Project!
Backport of PR #0000 to bareos-2x (remove this line if this is no backport; for backport use cherry-pick -x)
Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
Make sure you check/merge the PR using
devtools/pr-toolto have some simple automated checks run and a proper changelog record added.General
Check backport lineSource code quality
Tests