Conversation
9cb7f7b to
10f3235
Compare
arogge
requested changes
Jan 16, 2024
Member
arogge
left a comment
There was a problem hiding this comment.
Looks pretty good overall. I have a few questions and I think you should check if it makes sense to mark some of the cache variables as advanced, so they're hidden from the default-view in ccmake.
Member
Author
|
@arogge I applied your suggestion and also mark some of the variables as advanced. |
arogge
approved these changes
Jan 29, 2024
Member
arogge
left a comment
There was a problem hiding this comment.
Sorry for taking that long. This looks really, really good!
std::find_if is sometimes declared as [[nodiscard]]. As such we should not ignore its return value. This commit also slightly refactors the code to remove the use of std::find_if alltogether.
is_reloading can written to/ read from multiple different threads at the same time. As such we cannot just do a test-then-set approach (even if each of those operations were atomic). Instead we need to atomically test _and_ set the flag to actually prevent two different threads from entering.
The base config path may change on a reload!
exec_program is deprecated since cmake >= 3.0
The travis service is no longer used, therefore these files are no longer required.
Co-authored-by: Andreas Rogge <andreas.rogge@bareos.com>
Mark option, that are normally not manually set as advanced.
Some option are ON by default. This change marks them as advanced and removes them from the build descriptions.
0e8aa97 to
27ec66c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to the Bareos Project!
During PR #1592 it turns out that a number of cmake config settings could be cleaner,
especially when it comes to macOS configuration.
Instead of integrating this in the bugfixing PR, this is now handled in this separate PR.
This PR replaces #1610, as only a PR in https://github.com/bareos/bareos can be used to test the new macOS build workflow handling.
Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
Make sure you check/merge the PR using
devtools/pr-toolto have some simple automated checks run and a proper changelog record added.General
.github/workflows/build-macos.ymlavailable in bareos-23 (yes), bareos-22 (macOS build workflow (for Bareos-22) #1691) and bareos-21 (macOS build workflow #1692)?Source code quality