macOS: fix linking problem for macOS >= 14#1592
Merged
BareosBot merged 11 commits intobareos:masterfrom Dec 12, 2023
Merged
Conversation
59d1980 to
6147b21
Compare
arogge
requested changes
Nov 30, 2023
Member
arogge
left a comment
There was a problem hiding this comment.
You have another change mixed into this PR, but the macOS changes look good!
2d54552 to
97df537
Compare
97df537 to
7c288cf
Compare
This was referenced Dec 11, 2023
* Allow SSH connections during build. * Adds testing the Bareos package.
Paths and service names have been outdated (wrong).
required for macOS >= 14. Fixes bareos#1565: bareos-fd crash on macOS 14.1 Sonoma
Fix workingdir: /usr/local/var/lib/bareos (not existing) => /usr/local/bareos/var/lib/bareos Specify CMAKE_INSTALL_PREFIX as build parameter, instead of fixed in the cmake files.
for his help debugging bareos-fd on macOS 14.
The handling of bconsole.conf have been wrong in some cases. Now installing config files uses the same cmake code.
7c288cf to
4e9f6fa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
macOS build:
Tested in https://github.com/joergsteffens/bareos (master branch, to be able to trigger the workflows).
Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
Make sure you check/merge the PR using
devtools/pr-toolto have some simple automated checks run and a proper changelog record added.General
Source code quality