Skip to content

plugins: postgresql fix missing pg_backup_stop() call#1655

Merged
BareosBot merged 2 commits intobareos:masterfrom
bruno-at-bareos:dev/bruno/master/plugin-postgresql-fix-incrementals
Jan 16, 2024
Merged

plugins: postgresql fix missing pg_backup_stop() call#1655
BareosBot merged 2 commits intobareos:masterfrom
bruno-at-bareos:dev/bruno/master/plugin-postgresql-fix-incrementals

Conversation

@bruno-at-bareos
Copy link
Contributor

@bruno-at-bareos bruno-at-bareos commented Jan 9, 2024 •
edited
Loading

  • pg_backup_stop() is called in all job level
  • add in testrunner-default checks of WARNING or ERROR in db logs

Fixes #1584: Incremental PostgreSQL backup will log an warning on
the database server

OP#5669

Please check

  • Short description and the purpose of this PR is present above this paragraph
  • Your name is present in the AUTHORS file (optional)

If you have any questions or problems, please give a comment in the PR.

Helpful documentation and best practices

Checklist for the reviewer of the PR (will be processed by the Bareos team)

Make sure you check/merge the PR using devtools/pr-tool to have some simple automated checks run and a proper changelog record added.

General
  • Is the PR title usable as CHANGELOG entry?
  • Purpose of the PR is understood
  • Commit descriptions are understandable and well formatted
  • Check backport line
  • Required backport PRs have been created
Source code quality
  • Source code changes are understandable
  • Variable and function names are meaningful
  • Code comments are correct (logically and spelling)
  • Required documentation changes are present and part of the PR
Tests
  • Decision taken that a test is required (if not, then remove this paragraph)
  • The choice of the type of test (unit test or systemtest) is reasonable
  • Testname matches exactly what is being tested
  • On a fail, output of the test leads quickly to the origin of the fault

@bruno-at-bareos bruno-at-bareos force-pushed the dev/bruno/master/plugin-postgresql-fix-incrementals branch 2 times, most recently from fe5e37a to 08a63df Compare January 11, 2024 12:14
pstorz
pstorz requested changes Jan 13, 2024
View reviewed changes
pstorz
pstorz approved these changes Jan 15, 2024
View reviewed changes
@bruno-at-bareos bruno-at-bareos force-pushed the dev/bruno/master/plugin-postgresql-fix-incrementals branch from 84c7975 to d1476a8 Compare January 15, 2024 13:43
@bruno-at-bareos bruno-at-bareos mentioned this pull request Jan 15, 2024
Merged
6 tasks
@bruno-at-bareos
plugins: postgresql fix missing pg_backup_stop() call
b5f2eb1 
- pg_backup_stop() is called in all job level depending of the
  `backup_running` status. This allow a better support of
  incremental with no changes.
- add in testrunner-default checks of WARNING or ERROR in cluster
  logs
- is_backup_running boolean true if pg_backup_start has been run
- is_backup_full boolean true if backup level is Full
- apply black formatting suggestion

Fixes bareos#1584: Incremental PostgreSQL backup will log an warning on
             the database server

Signed-off-by: Bruno Friedmann <bruno.friedmann@bareos.com>
@bruno-at-bareos bruno-at-bareos force-pushed the dev/bruno/master/plugin-postgresql-fix-incrementals branch from d1476a8 to b5f2eb1 Compare January 16, 2024 12:54
@BareosBot BareosBot merged commit 78929b0 into bareos:master Jan 16, 2024
@bruno-at-bareos bruno-at-bareos deleted the dev/bruno/master/plugin-postgresql-fix-incrementals branch March 13, 2024 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pstorz pstorz pstorz approved these changes

Assignees

@pstorz pstorz

Labels

requires backport to 23

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bruno-at-bareos @pstorz @BareosBot