VMware Plugin: Run bareos_vadp_dumper with optimized parameters to increase backup performance#1631
Merged
BareosBot merged 4 commits intobareos:bareos-23from Dec 13, 2023
Conversation
arogge
approved these changes
Dec 13, 2023
The bareos_vadp_dumper is now called with performance optimized parameters. These parameters were added as additional plugin options so that they can be further tuned if necessary. The plugin code now calls API functions which use the searchIndex for getting details of the VM being backed up, this can accelerate backup jobs, especially if large amounts of VMs exist. This change also include better checks of plugin options and removes some obsolete code parts that are no longer needed as Python 2 is no longer supported. (cherry picked from commit 170f608)
Documentation of the new VMware Plugin options do_io_in_core, vadp_dumper_multithreading, vadp_dumper_sectors_per_call and vadp_dumper_query_allocated_blocks_chunk_size. Also updates the status, adds an description of the plugin components and changed defaults. (cherry picked from commit b19d063)
(cherry picked from commit 54aee2d)
f4ae0d1 to
49e7244
Compare
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to the Bareos Project!
Backport of PR #1630 to bareos-23
Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
Make sure you check/merge the PR using
devtools/pr-toolto have some simple automated checks run and a proper changelog record added.General
Source code quality