Skip to content

VMware Plugin: Run bareos_vadp_dumper with optimized parameters to increase backup performance#1630

Merged
BareosBot merged 4 commits intomasterfrom
dev/sduehr/master/vmware-plugin-adaptions
Dec 13, 2023
Merged

VMware Plugin: Run bareos_vadp_dumper with optimized parameters to increase backup performance#1630
BareosBot merged 4 commits intomasterfrom
dev/sduehr/master/vmware-plugin-adaptions

Conversation

@sduehr
Copy link
Member

@sduehr sduehr commented Dec 13, 2023 •
edited by pstorz
Loading

The bareos_vadp_dumper is now called with performance optimized parameters. These parameters were added as additional plugin options so that they can be further tuned if necessary.

The plugin code now calls API functions which use the searchIndex for getting details of the VM being backed up, this can accelerate backup jobs, especially if large amounts of VMs exist.

This change also include better checks of plugin options and removes some obsolete code parts that are no longer needed as Python 2 is no longer supported.

Thank you for contributing to the Bareos Project!

Please check

  • Short description and the purpose of this PR is present above this paragraph
  • Your name is present in the AUTHORS file (optional)

If you have any questions or problems, please give a comment in the PR.

Helpful documentation and best practices

Checklist for the reviewer of the PR (will be processed by the Bareos team)

Make sure you check/merge the PR using devtools/pr-tool to have some simple automated checks run and a proper changelog record added.

General
  • Is the PR title usable as CHANGELOG entry?
  • Purpose of the PR is understood
  • Commit descriptions are understandable and well formatted
  • Check backport line
  • Required backport PRs have been created
Source code quality
  • Source code changes are understandable
  • Variable and function names are meaningful
  • Code comments are correct (logically and spelling)
  • Required documentation changes are present and part of the PR

@sduehr sduehr requested a review from arogge December 13, 2023 14:11
arogge
arogge reviewed Dec 13, 2023
View reviewed changes
Copy link
Member

@arogge arogge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the plugin changes itself look good as far as I can tell.

@sduehr sduehr removed the draft label Dec 13, 2023
pstorz
pstorz reviewed Dec 13, 2023
View reviewed changes
@pstorz pstorz force-pushed the dev/sduehr/master/vmware-plugin-adaptions branch from 44f1e21 to 54aee2d Compare December 13, 2023 18:47
@pstorz pstorz mentioned this pull request Dec 13, 2023
Merged
11 tasks
sduehr and others added 4 commits December 13, 2023 19:52
@sduehr @BareosBot
VMware Plugin: bareos_vadp_dumper performance
0e75b28 
The bareos_vadp_dumper is now called with performance optimized
parameters. These parameters were added as additional plugin options so
that they can be further tuned if necessary.

The plugin code now calls API functions which use the searchIndex for
getting details of the VM being backed up, this can accelerate backup
jobs, especially if large amounts of VMs exist.

This change also include better checks of plugin options and removes
some obsolete code parts that are no longer needed as Python 2 is no
longer supported.
@sduehr @BareosBot
docs: New VMware Plugin options
83e2e28 
Documentation of the new VMware Plugin options do_io_in_core,
vadp_dumper_multithreading, vadp_dumper_sectors_per_call and
vadp_dumper_query_allocated_blocks_chunk_size. Also updates the status,
adds an description of the plugin components and changed defaults.
@pstorz @BareosBot
docs: apply review changes
32caa75
@BareosBot
Update CHANGELOG.md
f1fcbb8
@BareosBot BareosBot force-pushed the dev/sduehr/master/vmware-plugin-adaptions branch from 4aba4b8 to f1fcbb8 Compare December 13, 2023 19:52
@BareosBot BareosBot merged commit 819586f into master Dec 13, 2023
@BareosBot BareosBot deleted the dev/sduehr/master/vmware-plugin-adaptions branch December 13, 2023 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@arogge arogge arogge left review comments

@pstorz pstorz pstorz approved these changes

Assignees

No one assigned

Labels

requires backport to 23

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sduehr @pstorz @arogge @BareosBot