python: adapt for new Python module versions#1546
Merged
joergsteffens merged 7 commits intobareos:masterfrom Sep 28, 2023
Merged
python: adapt for new Python module versions#1546joergsteffens merged 7 commits intobareos:masterfrom
joergsteffens merged 7 commits intobareos:masterfrom
Conversation
8 tasks
f494b97 to
8f4c063
Compare
82d8c25 to
cccdf33
Compare
sduehr
requested changes
Sep 28, 2023
Member
sduehr
left a comment
There was a problem hiding this comment.
Thanks, looks good. Only one small suggestion.
18adc85 to
5562733
Compare
Member
Author
|
@sduehr I integrated your suggestion. Please check again. |
Bareos version numbers don't comply to PEP 440 and needs to be translated. Version translation has been adapted to the more strict requirements of the Python packaging modul >=23.
Don't require preinstalled python-bareos package, as this modul is used from the local checkout (and not available on the testing systems).
Co-authored-by: sduehr <stephan.duehr@bareos.com>
862353b to
13c3546
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes some changes, so that python-bareos and bareos-restapi are able to be used with the current versions of the Python modules
packaging(tested with 23.1) andpydantic(tested with 2.3.0).The pydantic problem has been reported by #1544
Backport of PR #0000 to bareos-2x (remove this line if this is no backport; for backport use cherry-pick -x)
Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
Make sure you check/merge the PR using
devtools/pr-toolto have some simple automated checks run and a proper changelog record added.General
Source code quality
Tests