Fix bug for PydanticSchemaGenerationError in rest_api#1544
Closed
grapemix wants to merge 1 commit intobareos:masterfrom
Closed
Fix bug for PydanticSchemaGenerationError in rest_api#1544grapemix wants to merge 1 commit intobareos:masterfrom
grapemix wants to merge 1 commit intobareos:masterfrom
Conversation
This patch locks down the pip package version to prevent the backward compatibility problem from pydantic 2.x. Since pydantic 2.x has been released, users will see the following error without this patch: pydantic.errors.PydanticSchemaGenerationError: Unable to generate pydantic-core schema for <class 'bareos_restapi.models.bareosACL'>. Set `arbitrary_types_allowed=True` in the model_config to ignore this error or implement `__get_pydantic_core_schema__` on your type to fully support it.
12 tasks
Member
|
Thank you for your contribution and for pointing out this issue. While this approach will work for most environments, it would require changes to our automated systemtest environment, as the content of the |
Member
|
Problem solved by #1546. Therefore this PR is no longer required. Thank you for pointing this problem out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch locks down the pip package version to prevent the backward compatibility problem from pydantic 2.x.
Since pydantic 2.x has been released, users will see the following error without this patch:
pydantic.errors.PydanticSchemaGenerationError: Unable to generate pydantic-core schema for <class 'bareos_restapi.models.bareosACL'>. Set
arbitrary_types_allowed=Truein the model_config to ignore this error or implement__get_pydantic_core_schema__on your type to fully support it.All the versions are from
pip freezefrom my Docker.Thank you for contributing to the Bareos Project!
Backport of PR #0000 to bareos-2x (remove this line if this is no backport; for backport use cherry-pick -x)
Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
Make sure you check/merge the PR using
devtools/pr-toolto have some simple automated checks run and a proper changelog record added.General
Source code quality
Tests
Tested in my Docker only