Skip to content

build: Add GitHub workflow to build MacOS packages#1489

Merged
pstorz merged 1 commit intobareos:masterfrom
arogge:dev/arogge/master/macos-build-workflow
Jun 26, 2023
Merged

build: Add GitHub workflow to build MacOS packages#1489
pstorz merged 1 commit intobareos:masterfrom
arogge:dev/arogge/master/macos-build-workflow

Conversation

@arogge
Copy link
Member

@arogge arogge commented Jun 22, 2023

Adds a workflow that allows you to build MacOS packages from a specified repository and ref. Optionally checking if the tree-sha matches what you expected.

Please check

  • Short description and the purpose of this PR is present above this paragraph
  • Your name is present in the AUTHORS file (optional)

If you have any questions or problems, please give a comment in the PR.

Helpful documentation and best practices

Checklist for the reviewer of the PR (will be processed by the Bareos team)

Make sure you check/merge the PR using devtools/pr-tool to have some simple automated checks run and a proper changelog record added.

General
  • Is the PR title usable as CHANGELOG entry?
  • Purpose of the PR is understood
  • Commit descriptions are understandable and well formatted
  • Check backport line
  • Required backport PRs have been created
Source code quality
  • Source code changes are understandable
  • Variable and function names are meaningful
  • Code comments are correct (logically and spelling)
  • Required documentation changes are present and part of the PR

@pstorz pstorz self-requested a review June 26, 2023 09:58
Copy link
Member

@pstorz pstorz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@pstorz pstorz changed the title Add GitHub workflow to build MacOS packages build: Add GitHub workflow to build MacOS packages Jun 26, 2023
@pstorz pstorz force-pushed the dev/arogge/master/macos-build-workflow branch 2 times, most recently from e8a0f29 to a03cc1b Compare June 26, 2023 10:03
@pstorz pstorz merged commit e166645 into bareos:master Jun 26, 2023
pstorz pushed a commit to pstorz/bareos that referenced this pull request Aug 14, 2023
Adds missing query parameter.
Update copyright year.

Fixes bareos#1489: broken storage pool link

(cherry picked from commit e2fdc8e)
pstorz pushed a commit to pstorz/bareos that referenced this pull request Aug 14, 2023
Adds missing query parameter.

Fixes bareos#1489: broken storage pool link

(cherry picked from commit e2fdc8e)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants