Skip to content

build: fix for gcc 13.1.1#1459

Merged
pstorz merged 1 commit intobareos:masterfrom
alaaeddineelamri:dev/alaaeddineelamri/master/gcc13_1_1-support
May 12, 2023
Merged

build: fix for gcc 13.1.1#1459
pstorz merged 1 commit intobareos:masterfrom
alaaeddineelamri:dev/alaaeddineelamri/master/gcc13_1_1-support

Conversation

@alaaeddineelamri
Copy link
Contributor

@alaaeddineelamri alaaeddineelamri commented May 8, 2023

Thank you for contributing to the Bareos Project!

We previously merged a PR that fixes some issues raised by gcc 13, but those fixes were only for gcc 13.0.1.
The updated gcc 13.1.1 raises another issue that this PR tries to fix.

Please check

  • Short description and the purpose of this PR is present above this paragraph
  • Your name is present in the AUTHORS file (optional)

If you have any questions or problems, please give a comment in the PR.

Helpful documentation and best practices

Checklist for the reviewer of the PR (will be processed by the Bareos team)

Make sure you check/merge the PR using devtools/pr-tool to have some simple automated checks run and a proper changelog record added.

General
  • Is the PR title usable as CHANGELOG entry?
  • Purpose of the PR is understood
  • Commit descriptions are understandable and well formatted
  • Check backport line
  • Required backport PRs have been created
Source code quality
  • Source code changes are understandable
  • Variable and function names are meaningful
  • Code comments are correct (logically and spelling)
  • Required documentation changes are present and part of the PR
Tests
  • Decision taken that a test is required (if not, then remove this paragraph)
  • The choice of the type of test (unit test or systemtest) is reasonable
  • Testname matches exactly what is being tested
  • On a fail, output of the test leads quickly to the origin of the fault

Copy link
Member

@pstorz pstorz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@pstorz pstorz changed the title Fix for gcc 13.1.1 failed build build: fix for gcc 13.1.1 May 12, 2023
@pstorz pstorz force-pushed the dev/alaaeddineelamri/master/gcc13_1_1-support branch from 73f4dc1 to fc04683 Compare May 12, 2023 09:19
@pstorz pstorz merged commit cbdf8fe into bareos:master May 12, 2023
@alaaeddineelamri
Copy link
Contributor Author

The fix that was supposed to be here was inadvertently committed somewhere else (6ee68b1) and merged with another PR (#1454) before this one during the same day, which meant the commit and subsequent change was skipped in this PR. It was only a matter of merging order, and the fix is available anyway.

Same thing happened for the fix on bareos-22, as equivalent PRs were merged there too.

The fix for GCC 13.1.1 was supposed to be in this commit afaa6ee.

Apologies for the confusion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants