Skip to content

daemons: update network handling when IP protocols unavailable#1454

Merged
pstorz merged 12 commits intobareos:masterfrom
alaaeddineelamri:dev/alaaeddineelamri/master/fix-fd-ipv6-crash
May 11, 2023
Merged

daemons: update network handling when IP protocols unavailable#1454
pstorz merged 12 commits intobareos:masterfrom
alaaeddineelamri:dev/alaaeddineelamri/master/fix-fd-ipv6-crash

Conversation

@alaaeddineelamri
Copy link
Contributor

@alaaeddineelamri alaaeddineelamri commented Apr 25, 2023

Thank you for contributing to the Bareos Project!

Description

Even though IPv6 has been widely available across platforms, there can be situations where it can be outright disabled. In that case, Bareos wouldn't be able to create IPv6 sockets and would abort, dumping core files along the way.

The above issue prompted this PR, which updates how Bareos daemons handle this kind of situation.

Please check

  • Short description and the purpose of this PR is present above this paragraph
  • Your name is present in the AUTHORS file (optional)

If you have any questions or problems, please give a comment in the PR.

Helpful documentation and best practices

Checklist for the reviewer of the PR (will be processed by the Bareos team)

Make sure you check/merge the PR using devtools/pr-tool to have some simple automated checks run and a proper changelog record added.

General
  • Is the PR title usable as CHANGELOG entry?
  • Purpose of the PR is understood
  • Commit descriptions are understandable and well formatted
  • Check backport line
  • Required backport PRs have been created
Source code quality
  • Source code changes are understandable
  • Variable and function names are meaningful
  • Code comments are correct (logically and spelling)
  • Required documentation changes are present and part of the PR
Tests
  • Decision taken that a test is required (if not, then remove this paragraph)
  • The choice of the type of test (unit test or systemtest) is reasonable
  • Testname matches exactly what is being tested
  • On a fail, output of the test leads quickly to the origin of the fault

@alaaeddineelamri alaaeddineelamri force-pushed the dev/alaaeddineelamri/master/fix-fd-ipv6-crash branch 3 times, most recently from 2d7f4bc to c166ab8 Compare April 25, 2023 15:20
@alaaeddineelamri alaaeddineelamri force-pushed the dev/alaaeddineelamri/master/fix-fd-ipv6-crash branch from c166ab8 to ea54a4f Compare April 28, 2023 09:22
@alaaeddineelamri alaaeddineelamri marked this pull request as ready for review May 2, 2023 10:58
@alaaeddineelamri alaaeddineelamri force-pushed the dev/alaaeddineelamri/master/fix-fd-ipv6-crash branch from ea54a4f to 4d100a5 Compare May 8, 2023 14:02
@alaaeddineelamri alaaeddineelamri force-pushed the dev/alaaeddineelamri/master/fix-fd-ipv6-crash branch from c794340 to 7df7426 Compare May 9, 2023 09:31
@alaaeddineelamri alaaeddineelamri requested a review from sebsura May 9, 2023 09:32
@alaaeddineelamri alaaeddineelamri force-pushed the dev/alaaeddineelamri/master/fix-fd-ipv6-crash branch from 7df7426 to 91f7136 Compare May 9, 2023 09:59
Copy link
Contributor

@sebsura sebsura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me!

@pstorz pstorz force-pushed the dev/alaaeddineelamri/master/fix-fd-ipv6-crash branch from 9c8b622 to 8d6a19d Compare May 11, 2023 10:41
@pstorz pstorz merged commit 90fb79e into bareos:master May 11, 2023
@alaaeddineelamri alaaeddineelamri mentioned this pull request May 23, 2023
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants