webui: improve localization process#1429
Merged
joergsteffens merged 4 commits intobareos:masterfrom Apr 4, 2023
Merged
Conversation
frb121
reviewed
Apr 4, 2023
frb121
reviewed
Apr 4, 2023
Contributor
|
I'd like to suggest changing the PR title to sth. like |
958d2d6 to
fee4c47
Compare
d0b9441 to
42688c5
Compare
Try to generate the translations files always in the same order, to minimize the differences between changes.
Some strings have been used multiple times but with different lower/upper-case writing. We change some of these string to a unified form.
Add a hint, that new languages can now also be added by poeditor.com
0332a8d to
210a8fa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Have the msgids in the pot and po always in the same order.
This should make diffs between language commits smaller and easier to read.
Remove some msgids by choosing the some upper/lower-case writing as in other occurrences.
Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
Make sure you check/merge the PR using
devtools/pr-toolto have some simple automated checks run and a proper changelog record added.General
Source code quality