Skip to content

stored: fix crashes of storage tools when autoxflate plugin is loaded#1369

Merged
arogge merged 11 commits intobareos:bareos-22from
arogge:dev/pstorz/bareos-22/fix-bls-crash
Feb 7, 2023
Merged

stored: fix crashes of storage tools when autoxflate plugin is loaded#1369
arogge merged 11 commits intobareos:bareos-22from
arogge:dev/pstorz/bareos-22/fix-bls-crash

Conversation

@arogge
Copy link
Member

@arogge arogge commented Feb 3, 2023 •
edited
Loading

Backport of PR #1348 to bareos-22 (remove this line, if it no backport)

Please check

  • Short description and the purpose of this PR is present above this paragraph
  • Your name is present in the AUTHORS file (optional)

If you have any questions or problems, please give a comment in the PR.

Helpful documentation and best practices

Checklist for the reviewer of the PR (will be processed by the Bareos team)

Make sure you check/merge the PR using devtools/pr-tool to have some simple automated checks run and a proper changelog record added.

General
  • Is the PR title usable as CHANGELOG entry?
  • Purpose of the PR is understood
  • Commit descriptions are understandable and well formatted
  • Check backport line
Source code quality
  • Source code changes are understandable
  • Variable and function names are meaningful
  • Code comments are correct (logically and spelling)
  • Required documentation changes are present and part of the PR
Tests
  • Decision taken that a test is required (if not, then remove this paragraph)
  • The choice of the type of test (unit test or systemtest) is reasonable
  • Testname matches exactly what is being tested
  • On a fail, output of the test leads quickly to the origin of the fault

@arogge arogge requested a review from pstorz February 3, 2023 12:27
pstorz
pstorz approved these changes Feb 7, 2023
View reviewed changes
Copy link
Member

@pstorz pstorz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work!

pstorz and others added 11 commits February 7, 2023 10:42
@pstorz @arogge
autoxflate: verify valid compress.deflate_buffer
a94d3cf 
(cherry picked from commit bd9eb37)
@pstorz @arogge
bls.cc: call bSdEventSetupRecordTranslation
a2e5dc7 
This call lets the autoxflate plugin setup the compression buffers.

(cherry picked from commit 6ebb09f)
@pstorz @arogge
stored tools: callbSdEventSetupRecordTranslation
36a66d5 
(cherry picked from commit 92a1bd8)
@pstorz @arogge
systemtests: run bls,bscan,bextract with autoxflate
1475093 
(cherry picked from commit 3b53e94)
@pstorz @arogge
bscan: minimized memleaks
3370610 
(cherry picked from commit 3926f2d)
@pstorz @arogge
bextract, bls; minimized leaks
6872e8d 
(cherry picked from commit 463bc4b)
@pstorz @arogge
systemtests: introduce testrunner-bcopy-autoxflate
51fba08 
(cherry picked from commit 057ccf1)
@pstorz @arogge
bcopy: reduce memleak
309537f 
(cherry picked from commit 6ce2c96)
@arogge
stored: fix leak when reading translated records
77fbcf1 
When records are translated by a plugin the plugin will allocate its own
record. In this scenario ReadRecords() is supposed to call FreeRecord()
which it didn't do.

(cherry picked from commit 5874bc4)
@arogge
systemtests: adapt to renamed bareos-basic test
3b047b8 
(cherry picked from commit b109580)
@arogge
Update CHANGELOG.md
0aa09e0
@arogge arogge force-pushed the dev/pstorz/bareos-22/fix-bls-crash branch from 574a0a4 to 0aa09e0 Compare February 7, 2023 09:42
@arogge arogge merged commit 1665d91 into bareos:bareos-22 Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pstorz pstorz pstorz approved these changes

Assignees

No one assigned

Labels

is a backport to 22

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@arogge @pstorz