stored: fix crashes of storage tools when autoxflate plugin is loaded#1348
Merged
stored: fix crashes of storage tools when autoxflate plugin is loaded#1348
Conversation
96b50aa to
0fdc73f
Compare
arogge
reviewed
Jan 18, 2023
arogge
requested changes
Jan 24, 2023
Member
arogge
left a comment
There was a problem hiding this comment.
The tests look promising, but apparently we have memory leaks in the tools when autoxflate is enabled, thus the tests fail in the sanitizer stage.
I think there is also a fixture missing, as with enough parallelism (i.e. -j 100) the tests failed on my machine, too.
5bdb0d8 to
0b112db
Compare
arogge
approved these changes
Feb 2, 2023
2698bbf to
fa08600
Compare
This call lets the autoxflate plugin setup the compression buffers.
When records are translated by a plugin the plugin will allocate its own record. In this scenario ReadRecords() is supposed to call FreeRecord() which it didn't do.
fa08600 to
10ddce9
Compare
10ddce9 to
b109580
Compare
This was referenced Feb 3, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The low level storage tools bcopy, bextract, bls, bscan and btape load sd plugins if they are configured.
Unfortunately, the plugin event
bSdEventSetupRecordTranslationwas not emitted before, so that the autoxflate plugin did not setup the compression buffers.Now, all these tools do emit the plugin event, and the autoxflate-sd plugin also checks for the buffer before using it and emits an message otherwise.
Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
General
Separate commit for CHANGELOG.md ("update CHANGELOG.md"). The PR number is correct.Source code quality
bareos-check-sources --since-mergedoes not report any problemsTests