Conversation
cc8b5bc to
4ebcf4e
Compare
905c7f5 to
10d4cc9
Compare
Previously the RPM depsolver selected the python2 plugins. So if you installed bareos-filedaemon-postgresql-python-plugin that would require bareos-filedaemon-python-plugin which in turn was resolved by adding bareos-filedaemon-python2-plugin to the transaction. With the suggests added with this patch, the depsolver will not prefer the python3 plugin, so that in the above example bareos-filedaemon-python3-plugin would be installed. As rpm on RHEL 7 does not yet support suggests, the fix does not apply to that platform.
Previously the python plugins depended on a virtual provides. This lead to a situation where the python2 and python3 plugin were treated equally and were both installed by default. By changing this to basically "Depends: python3-plugin | python2-plugin" the depsolver will not prefer python3 and not install python2 unless you explitictly require it.
10d4cc9 to
408203f
Compare
arogge
approved these changes
Dec 14, 2022
Member
arogge
left a comment
There was a problem hiding this comment.
Dependency resolution is pretty weird. We finally got it working and that status should be merged.
alaaeddineelamri
pushed a commit
that referenced
this pull request
Dec 30, 2022
python plugins: give python3 plugins priority over python2 plugins in packages
alaaeddineelamri
pushed a commit
that referenced
this pull request
Dec 30, 2022
python plugins: give python3 plugins priority over python2 plugins in packages
alaaeddineelamri
pushed a commit
that referenced
this pull request
Dec 30, 2022
python plugins: give python3 plugins priority over python2 plugins in packages
alaaeddineelamri
pushed a commit
that referenced
this pull request
Dec 31, 2022
python plugins: give python3 plugins priority over python2 plugins in packages
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to the Bareos Project!
The python2 plugin packages have been renamed to python27-plugin, so that the preferred python3 plugin version will be installed first instead of the deprecated python2 version.
Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
General
Separate commit for CHANGELOG.md ("update CHANGELOG.md"). The PR number is correct.Source code quality
bareos-check-sources --since-mergedoes not report any problems