VMware Plugin: Save VM configuration and recreate VM before restore#1295
Merged
VMware Plugin: Save VM configuration and recreate VM before restore#1295
Conversation
pstorz
reviewed
Oct 26, 2022
Member
pstorz
left a comment
There was a problem hiding this comment.
Partly reviewed, will continue later from line 2406.
docs/manuals/source/TasksAndConcepts/Plugins/FileDaemonPlugins/VMwarePlugin.rst.inc
Outdated
Show resolved
Hide resolved
docs/manuals/source/TasksAndConcepts/Plugins/FileDaemonPlugins/VMwarePlugin.rst.inc
Outdated
Show resolved
Hide resolved
docs/manuals/source/TasksAndConcepts/Plugins/FileDaemonPlugins/VMwarePlugin.rst.inc
Outdated
Show resolved
Hide resolved
pstorz
requested changes
Oct 27, 2022
Member
pstorz
left a comment
There was a problem hiding this comment.
Great work, very impressive!
See comments.
sduehr
added a commit
that referenced
this pull request
Nov 8, 2022
sduehr
added a commit
that referenced
this pull request
Nov 8, 2022
0210d0c to
58adaf4
Compare
sduehr
added a commit
that referenced
this pull request
Nov 8, 2022
58adaf4 to
74bca8f
Compare
pstorz
requested changes
Nov 14, 2022
Member
pstorz
left a comment
There was a problem hiding this comment.
Please see comments. Good work!
docs/manuals/source/TasksAndConcepts/Plugins/FileDaemonPlugins/VMwarePlugin.rst.inc
Outdated
Show resolved
Hide resolved
docs/manuals/source/TasksAndConcepts/Plugins/FileDaemonPlugins/VMwarePlugin.rst.inc
Outdated
Show resolved
Hide resolved
docs/manuals/source/TasksAndConcepts/Plugins/FileDaemonPlugins/VMwarePlugin.rst.inc
Outdated
Show resolved
Hide resolved
sduehr
added a commit
that referenced
this pull request
Nov 22, 2022
The plugin now also saves the VM configuration on backup and recreates the VM if it was delete before restoring the virtual disk. It is also possible now to restore to different folder, host, cluster or datastore. Custom attributes are saved and restored, uuid and MAC address are restored if there are no duplicate conflicts.
If a snapshot existed at backup time, the backing filename must be adapted when recreating the VM.
edb7717 to
2088776
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The plugin now also saves the VM configuration on backup and recreates the VM if it was delete before restoring the virtual disk. It is also possible now to restore to different folder, host, cluster or datastore. Custom attributes are saved and restored, uuid and MAC address are restored if there are no duplicate conflicts.
Checklist for the reviewer of the PR (will be processed by the Bareos team)
General
Source code quality
bareos-check-sources --since-mergedoes not report any problems