Skip to content

webui: switch from mod_php to php-fpm#1287

Merged
pstorz merged 9 commits intobareos:masterfrom
frb121:dev/fbergkemper/master/s5207
Dec 1, 2022
Merged

webui: switch from mod_php to php-fpm#1287
pstorz merged 9 commits intobareos:masterfrom
frb121:dev/fbergkemper/master/s5207

Conversation

@frb121
Copy link
Contributor

@frb121 frb121 commented Oct 20, 2022 •
edited by pstorz
Loading

Replace mod_php requirement with php-fpm.

Thank you for contributing to the Bareos Project!

Please check

  • Short description and the purpose of this PR is present above this paragraph
  • Your name is present in the AUTHORS file (optional)

If you have any questions or problems, please give a comment in the PR.

Helpful documentation and best practices

Checklist for the reviewer of the PR (will be processed by the Bareos team)

General
  • PR name is meaningful
  • Purpose of the PR is understood
  • Commit descriptions are understandable and well formatted
  • Check backport line
  • Is the PR title usable as CHANGELOG entry?
  • Separate commit for CHANGELOG.md ("update CHANGELOG.md"). The PR number is correct.
  • CHANGELOG.md "breakin changes" entry with info that mod_php has been changed to php_fpm, and link to what needs to be done when upgrading.
  • Merge corresponding PR in git.bareos.com/ci-scripts
Source code quality
  • Source code changes are understandable
  • Variable and function names are meaningful
  • Code comments are correct (logically and spelling)
  • Required documentation changes are present and part of the PR
  • bareos-check-sources --since-merge does not report any problems

@frb121 frb121 self-assigned this Oct 20, 2022
@frb121 frb121 changed the title webui: make use of php-fpm default on all platforms webui: drop mod_php in favor of php-fpm Nov 3, 2022
@frb121 frb121 changed the title webui: drop mod_php in favor of php-fpm packaging: drop mod_php in favor of php-fpm Nov 3, 2022
@frb121 frb121 marked this pull request as ready for review November 4, 2022 11:22
@frb121 frb121 requested a review from pstorz November 4, 2022 11:22
@pstorz pstorz changed the title packaging: drop mod_php in favor of php-fpm packaging: switch from mod_php to php-fpm Nov 7, 2022
pstorz
pstorz requested changes Nov 7, 2022
View reviewed changes
Copy link
Member

@pstorz pstorz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check my remarks. Also, the last build failed in the doc stage, but probably that was only a glitch. It is currently rebuilding.

@frb121 frb121 requested a review from pstorz November 9, 2022 12:58
@frb121 frb121 assigned pstorz and unassigned frb121 Nov 17, 2022
pstorz
pstorz reviewed Nov 23, 2022
View reviewed changes
pstorz
pstorz previously approved these changes Nov 23, 2022
View reviewed changes
bruno-at-bareos
bruno-at-bareos reviewed Nov 24, 2022
View reviewed changes
bruno-at-bareos
bruno-at-bareos reviewed Nov 24, 2022
View reviewed changes
@pstorz pstorz self-requested a review November 24, 2022 13:26
@pstorz pstorz dismissed their stale review November 24, 2022 13:27

New comments were added

@pstorz pstorz changed the title packaging: switch from mod_php to php-fpm webui: switch from mod_php to php-fpm Dec 1, 2022
@pstorz pstorz enabled auto-merge December 1, 2022 18:55
@pstorz pstorz merged commit 2cccf70 into bareos:master Dec 1, 2022
alaaeddineelamri pushed a commit that referenced this pull request Dec 30, 2022
@pstorz
Merge pull request #1287
c8c3668 
webui: switch from  mod_php to php-fpm
alaaeddineelamri pushed a commit that referenced this pull request Dec 30, 2022
@pstorz
Merge pull request #1287
0e94acd 
webui: switch from  mod_php to php-fpm
alaaeddineelamri pushed a commit that referenced this pull request Dec 30, 2022
@pstorz
Merge pull request #1287
1d830e5 
webui: switch from  mod_php to php-fpm
alaaeddineelamri pushed a commit that referenced this pull request Dec 31, 2022
@pstorz
Merge pull request #1287
c01d076 
webui: switch from  mod_php to php-fpm
@frb121 frb121 deleted the dev/fbergkemper/master/s5207 branch April 21, 2023 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joergsteffens joergsteffens joergsteffens left review comments

@bruno-at-bareos bruno-at-bareos bruno-at-bareos left review comments

@pstorz pstorz pstorz approved these changes

Assignees

@pstorz pstorz

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@frb121 @pstorz @joergsteffens @bruno-at-bareos