webui: introduce themes#1281
webui: introduce themes#1281joergsteffens merged 11 commits intobareos:masterfrom frb121:dev/fbergkemper/master/s5160
Conversation
docs/manuals/source/IntroductionAndTutorial/InstallingBareosWebui.rst
Outdated
Show resolved
Hide resolved
docs/manuals/source/IntroductionAndTutorial/InstallingBareosWebui.rst
Outdated
Show resolved
Hide resolved
docs/manuals/source/IntroductionAndTutorial/InstallingBareosWebui.rst
Outdated
Show resolved
Hide resolved
docs/manuals/source/IntroductionAndTutorial/InstallingBareosWebui.rst
Outdated
Show resolved
Hide resolved
sebastianlederer
left a comment
There was a problem hiding this comment.
The file bareos-logo.png does not seem to be used at all. In my test install, I deleted these files without any noticable effect:
deleted: public/img/bareos-logo.png
deleted: public/themes/default/img/bareos-logo.png
deleted: public/themes/slate/img/bareos-logo.png
deleted: public/themes/sunflower/img/bareos-logo.png
So it is likely that these files can be removed entirely.
The other redundant PNG files and font files are probably unavoidable without much more changes in the PHP code and in the bootstrap CSS.
I'd really like to avoid removing original source image material from source tree even if it's not actively used in the application currently. If a theme doesn't and probably never will use the mentioned one above, we could remove it, I agree. But let's keep and not touch originals in the default image folder (public/img/). Our README.md for example references an image located in here as well, If we want to reduce application size, build and packaging should handle this. We could move the img folder one directory up to place it in webui root folder and have the source image material available there, I guess. That might already exclude it from being packaged, but I have to check that out. In addition this change would require to adjust the image reference in our https://github.com/bareos/bareos/blob/master/README.md . |
|
Removed unused image material from themes except one source image for reference in the default theme folder I'd like to keep for now. Also adjusted the Bareos logo include in our README.md in a separate commit due to the recent changes. |
|
Note: This PR requires #1313 to be merged first. Afterwards we need to rebase this one. |
|
Removed the experimental |
|
Updated PR title and description. |
|
CHANGELOG.md needs to be adjusted. |
|
We should also squash commits before merge for a clean commit history. I kept it due to the review process for now as it is. |
|
It might be good idea, to refer to the source of the sunflower picture, at least in the git commit message. |
Thanks to David Travis for the sunflower background image. https://unsplash.com/@dtravisphd
Signed-off-by: Frank Bergkemper <frank.bergkemper@bareos.com>
Suggestions got applied.
Introduces two themes called
defaultandsunflower. Thesunflowertheme is default for now.Thank you for contributing to the Bareos Project!
Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
General
Source code quality
bareos-check-sources --since-mergedoes not report any problems