systemtests: improve webui testing#1313
Merged
joergsteffens merged 6 commits intobareos:masterfrom Nov 21, 2022
Merged
Conversation
Contributor
|
I'd prefer the following PR title as basically just systemtests is touched besides one minor exception. systemtests: improve webui testing |
frb121
reviewed
Nov 16, 2022
frb121
previously approved these changes
Nov 18, 2022
With webui.sh it is possible to start the WebUI server in every systemtest test directory.
9809f7e to
2542504
Compare
Before, the configuration.ini file has been required to start the WebUI. However, as all values got default values defined in the script anyway, this is not required and has therefore be removed. Also the handling of the default values has been simplified.
Signed-off-by: Frank Bergkemper <frank.bergkemper@bareos.com>
2542504 to
3694f1b
Compare
frb121
approved these changes
Nov 21, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR cleans up the WebUI systemtests a bit and helps testing the WebUI.
Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
General
Source code quality
bareos-check-sources --since-mergedoes not report any problems