Merged
Conversation
b71d6eb to
ceba1ea
Compare
f14774f to
d47a638
Compare
arogge
reviewed
Sep 19, 2022
.matrix.yml
Outdated
| "F37": | ||
| TYPE: scripted | ||
| IMAGE: fedora37 | ||
| BUILD_SCRIPT: CD/sanitize/build-sanitize.sh |
Member
There was a problem hiding this comment.
we can move that to the Bareos repository, you just use "bareos/..." as a path here.
The script path is relative to Jenkins' $WORKSPACE and it always run with cwd set to the top of the cloned bareos repository.
So you can test and develop the script locally and it should just work in Jenkins.
4428bdf to
8214c38
Compare
6546026 to
bad4037
Compare
The code before did not check for the return value of binary_insert(), so that the failed inserts were not freed.
Signed-off-by: Bruno Friedmann <bruno.friedmann@bareos.com>
Add a stage with F37 building with a custom script, enabling sanitizers and running tests. Also cleanup the .matrix.yml a bit. Co-Authored-By: Andreas Rogge <andreas.rogge@bareos.com>
bad4037 to
b6fd36b
Compare
arogge
approved these changes
Oct 4, 2022
alaaeddineelamri
pushed a commit
that referenced
this pull request
Dec 31, 2022
Build: add sanitizer stages
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the option to run the bareos tests with sanitizers enabled ("-D ENABLE_SANITIZERS=yes") to immediately detect memory problems that the sanitzers can detect.
It also introduces the test label
broken_with_enabled_sanitzerswhich marks tests that do not work with sanitizers enabled. These tests are skipped in the sanitizer stage.It also fixes a memleak that was detected by the sanitizers stage in
mntent_cache.ccPlease check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
General