core:platform Add Bareos firewalld services#1237
Merged
joergsteffens merged 2 commits intobareos:masterfrom Aug 25, 2022
Merged
core:platform Add Bareos firewalld services#1237joergsteffens merged 2 commits intobareos:masterfrom
joergsteffens merged 2 commits intobareos:masterfrom
Conversation
73d6be3 to
4c03c82
Compare
joergsteffens
requested changes
Aug 25, 2022
feaa58a to
f7cfc02
Compare
f7cfc02 to
06927b3
Compare
- xml service files will be proposed to firewalld upstream project. short description has be done following Bareos Style Guide for common names. Signed-off-by: Bruno Friedmann <bruno.friedmann@bareos.com> Co-authored-by: Jörg Steffens <joergsteffens@users.noreply.github.com>
Signed-off-by: Bruno Friedmann <bruno.friedmann@bareos.com>
b46298c to
e2c22e5
Compare
joergsteffens
approved these changes
Aug 25, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is about preparing official Bareos firewalld services xml before submitting them to upstream.
upstream PR#1009 is now open
OP#4665
Thank you for contributing to the Bareos Project!
Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
General
[ ] If backport: add original PR number and target branch at top of this file: Backport of PR#000 to bareos-2xSource code quality
bareos-check-sources --since-mergedoes not report any problemsgit statusshould not report modifications in the source tree after building and testing