feat(service): add bareos-director bareos-filedaemon bareos-storage#1009
feat(service): add bareos-director bareos-filedaemon bareos-storage#1009erig0 merged 1 commit intofirewalld:masterfrom bruno-at-bareos:add-bareos-firewalld-services
Conversation
- Add bareos-director (bareos-dir) service definition for default port 9101. - Add bareos-filedaemon (bareos-fd) service definition for default port 9102. - Add bareos-storage (bareos-sd) service definition for default port 9103. Signed-off-by: Bruno Friedmann <bruno.friedmann@bareos.com>
|
Hi Bruno, I just want to double confirm that you want firewalld to ship these service definitions. Some projects prefer to ship the definitions as part of their package. That may make it easier to manage version differences, avoid package conflicts, etc. See #1002 (and #552) for one such case. I'm more than happy to take these though. Just let me know. |
erig0
left a comment
There was a problem hiding this comment.
lgtm. Just waiting on confirmation.
|
Hello @erig0 yes the protocol will not change, nor the port, and we have reviewed together the name, description etc before submitting here. And if something has to be corrected, then we will do another Pr ;-) Thanks for taking care of the PR so quickly. I hope everything was ok. |
Awesome! Thanks.
Perfect. :) |
Signed-off-by: Bruno Friedmann bruno.friedmann@bareos.com