Skip to content

Remove deprecated rados/ceph code and packages#1216

Merged
pstorz merged 5 commits intobareos:masterfrom
bruno-at-bareos:dev/bruno/master/t5204_remove_deprecated_rados-ceph
Aug 19, 2022
Merged

Remove deprecated rados/ceph code and packages#1216
pstorz merged 5 commits intobareos:masterfrom
bruno-at-bareos:dev/bruno/master/t5204_remove_deprecated_rados-ceph

Conversation

@bruno-at-bareos
Copy link
Contributor

@bruno-at-bareos bruno-at-bareos commented Aug 9, 2022

This PR will remove deprecated code for filedaemon ceph plugins and ceph/rados storage backend.
It also cleanup the documentation.

There's one question still open about the packaging is how people upgrading from previous version will have their previously installed packages removed.

Please check

  • Short description and the purpose of this PR is present above this paragraph
  • Your name is present in the AUTHORS file (optional)

If you have any questions or problems, please give a comment in the PR.

Helpful documentation and best practices

Checklist for the reviewer of the PR (will be processed by the Bareos team)

General
  • PR name is meaningful
  • Purpose of the PR is understood
  • Separate commit for this PR in the CHANGELOG.md, PR number referenced is same
  • Commit descriptions are understandable and well formatted
Source code quality
  • Source code changes are understandable
  • Variable and function names are meaningful
  • Code comments are correct (logically and spelling)
  • Required documentation changes are present and part of the PR
  • bareos-check-sources --since-merge does not report any problems
  • git status should not report modifications in the source tree after building and testing

@bruno-at-bareos bruno-at-bareos requested a review from pstorz August 9, 2022 17:11
@bruno-at-bareos bruno-at-bareos force-pushed the dev/bruno/master/t5204_remove_deprecated_rados-ceph branch from bf288eb to b8deff9 Compare August 10, 2022 08:45
@bruno-at-bareos bruno-at-bareos force-pushed the dev/bruno/master/t5204_remove_deprecated_rados-ceph branch from a2fa3de to 097df8a Compare August 11, 2022 12:19
Copy link
Member

@pstorz pstorz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The second sentence should be carified: "There's one question still open about the packaging is how people upgrading from previous version will have their previously installed packages removed."

We just have to put that fact into the release notes in breaking changes, so that everybody can see that the packages have changed.

bruno-at-bareos added a commit to bruno-at-bareos/bareos that referenced this pull request Aug 11, 2022
Co-authored-by: Philipp Storz <philipp.storz@bareos.com>
bruno-at-bareos added a commit to bruno-at-bareos/bareos that referenced this pull request Aug 11, 2022
Signed-off-by: Bruno Friedmann <bruno.friedmann@bareos.com>
Co-authored-by: Philipp Storz <philipp.storz@bareos.com>
@bruno-at-bareos bruno-at-bareos force-pushed the dev/bruno/master/t5204_remove_deprecated_rados-ceph branch from 5415aa7 to 6bd30fc Compare August 11, 2022 15:02
bruno-at-bareos added a commit to bruno-at-bareos/bareos that referenced this pull request Aug 11, 2022
Signed-off-by: Bruno Friedmann <bruno.friedmann@bareos.com>
Co-authored-by: Philipp Storz <philipp.storz@bareos.com>
Signed-off-by: Bruno Friedmann <bruno.friedmann@bareos.com>
@bruno-at-bareos bruno-at-bareos force-pushed the dev/bruno/master/t5204_remove_deprecated_rados-ceph branch from 6bd30fc to 97c29c0 Compare August 11, 2022 15:11
@bruno-at-bareos bruno-at-bareos requested a review from pstorz August 11, 2022 15:12
bruno-at-bareos added a commit to bruno-at-bareos/bareos that referenced this pull request Aug 17, 2022
Signed-off-by: Bruno Friedmann <bruno.friedmann@bareos.com>
Co-authored-by: Philipp Storz <philipp.storz@bareos.com>
Signed-off-by: Bruno Friedmann <bruno.friedmann@bareos.com>
@bruno-at-bareos bruno-at-bareos force-pushed the dev/bruno/master/t5204_remove_deprecated_rados-ceph branch from 97c29c0 to 21c2eb1 Compare August 17, 2022 15:35
bruno-at-bareos added a commit to bruno-at-bareos/bareos that referenced this pull request Aug 18, 2022
Signed-off-by: Bruno Friedmann <bruno.friedmann@bareos.com>
Co-authored-by: Philipp Storz <philipp.storz@bareos.com>
Signed-off-by: Bruno Friedmann <bruno.friedmann@bareos.com>
@bruno-at-bareos bruno-at-bareos force-pushed the dev/bruno/master/t5204_remove_deprecated_rados-ceph branch from 045d950 to ab23cca Compare August 18, 2022 13:54
bruno-at-bareos and others added 4 commits August 18, 2022 15:56
- remove rados backend storage.
- remove filed cephfs and rados plugin.
- remove all *ceph* packages from doc/pkglists.
- apply clang-format to stored/sd_backends.cc and stored_conf.cc.

Signed-off-by: Bruno Friedmann <bruno.friedmann@bareos.com>

core: cmake adapt clang-format comment in .cmake

Signed-off-by: Bruno Friedmann <bruno.friedmann@bareos.com>
Signed-off-by: Bruno Friedmann <bruno.friedmann@bareos.com>
- apply copyright update and fix trailing newlines
- restore clang-formating error
- restore comments and block formating

Signed-off-by: Bruno Friedmann <bruno.friedmann@bareos.com>
Signed-off-by: Bruno Friedmann <bruno.friedmann@bareos.com>
Co-authored-by: Philipp Storz <philipp.storz@bareos.com>
Signed-off-by: Bruno Friedmann <bruno.friedmann@bareos.com>
@pstorz pstorz force-pushed the dev/bruno/master/t5204_remove_deprecated_rados-ceph branch from ab23cca to bb5c0c6 Compare August 18, 2022 13:57
Copy link
Member

@pstorz pstorz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work!

@pstorz pstorz merged commit c1ec547 into bareos:master Aug 19, 2022
@bruno-at-bareos bruno-at-bareos deleted the dev/bruno/master/t5204_remove_deprecated_rados-ceph branch August 23, 2022 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants