Skip to content

Build MacOS packages via Github Actions#1192

Merged
joergsteffens merged 2 commits intobareos:masterfrom
joergsteffens:dev/joergs/master/build-macos
Jul 7, 2022
Merged

Build MacOS packages via Github Actions#1192
joergsteffens merged 2 commits intobareos:masterfrom
joergsteffens:dev/joergs/master/build-macos

Conversation

@joergsteffens
Copy link
Member

@joergsteffens joergsteffens commented Jun 22, 2022

Thank you for contributing to the Bareos Project!

Add a github actions workflow to allow triggering to build a MacOS package for Bareos.

Please check

  • Short description and the purpose of this PR is present above this paragraph
  • Your name is present in the AUTHORS file (optional)

If you have any questions or problems, please give a comment in the PR.

Helpful documentation and best practices

Checklist for the reviewer of the PR (will be processed by the Bareos team)

General
  • PR name is meaningful
  • Purpose of the PR is understood
  • Separate commit for this PR in the CHANGELOG.md, PR number referenced is same
  • Commit descriptions are understandable and well formatted
  • [ ] If backport: add original PR number and target branch at top of this file: Backport of PR#000 to bareos-2x
Source code quality
  • Source code changes are understandable
  • Variable and function names are meaningful
  • Code comments are correct (logically and spelling)
  • [ ] Required documentation changes are present and part of the PR
  • bareos-check-sources --since-merge does not report any problems
  • git status should not report modifications in the source tree after building and testing

@joergsteffens joergsteffens self-assigned this Jun 22, 2022
@joergsteffens joergsteffens force-pushed the dev/joergs/master/build-macos branch 2 times, most recently from 7ac9bb5 to ae96a5a Compare June 27, 2022 14:19
@joergsteffens joergsteffens marked this pull request as ready for review June 27, 2022 14:21
@joergsteffens joergsteffens requested a review from arogge June 27, 2022 14:22
@HediBenFraj HediBenFraj self-requested a review July 5, 2022 17:26
Copy link
Contributor

@HediBenFraj HediBenFraj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good and understandable.

@joergsteffens joergsteffens force-pushed the dev/joergs/master/build-macos branch from ae96a5a to e1e1d47 Compare July 6, 2022 13:09
@joergsteffens joergsteffens requested review from HediBenFraj and removed request for arogge July 6, 2022 13:11
@bruno-at-bareos
Copy link
Contributor

@HediBenFraj you should also check all checkboxes tasks before approving the PR.

@joergsteffens joergsteffens merged commit 6a41db3 into bareos:master Jul 7, 2022
@joergsteffens joergsteffens deleted the dev/joergs/master/build-macos branch July 7, 2022 10:58
joergsteffens added a commit that referenced this pull request Aug 25, 2022
As the change removes the content of the earlier PR #1192,
it also removes the mentioning of this PR.
bruno-at-bareos pushed a commit to bruno-at-bareos/bareos that referenced this pull request Aug 29, 2022
As the change removes the content of the earlier PR bareos#1192,
it also removes the mentioning of this PR.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants