Skip to content

console: aborting job run if jobId doesn't exist in catalog.#1188

Merged
joergsteffens merged 5 commits intobareos:masterfrom
HediBenFraj:dev/HediBenFraj/master/jobid-availabilty-check-exexcuting-run-command
Jul 7, 2022
Merged

console: aborting job run if jobId doesn't exist in catalog.#1188
joergsteffens merged 5 commits intobareos:masterfrom
HediBenFraj:dev/HediBenFraj/master/jobid-availabilty-check-exexcuting-run-command

Conversation

@HediBenFraj
Copy link
Contributor

@HediBenFraj HediBenFraj commented Jun 10, 2022

Description

Check whether a given jobId exists in the database before executing the run command and abort if it doesn't.

  • Short description and the purpose of this PR is present above this paragraph
  • Your name is present in the AUTHORS file (optional)

If you have any questions or problems, please give a comment in the PR.

Helpful documentation and best practices

Checklist for the reviewer of the PR (will be processed by the Bareos team)

General
  • PR name is meaningful
  • Purpose of the PR is understood
  • Separate commit for this PR in the CHANGELOG.md, PR number referenced is same
  • Commit descriptions are understandable and well formatted
    - [ ] If backport: add original PR number and target branch at top of this file: Backport of PR#000 to bareos-2x
Source code quality
  • Source code changes are understandable
  • Variable and function names are meaningful
  • Code comments are correct (logically and spelling)
  • Required documentation changes are present and part of the PR
  • bareos-check-sources --since-merge does not report any problems
  • git status should not report modifications in the source tree after building and testing
Tests
  • Decision taken that a test is required (if not, then remove this paragraph)
  • The choice of the type of test (unit test or systemtest) is reasonable
  • Testname matches exactly what is being tested
  • On a fail, output of the test leads quickly to the origin of the fault

@HediBenFraj HediBenFraj force-pushed the dev/HediBenFraj/master/jobid-availabilty-check-exexcuting-run-command branch from af9cafa to c680ce4 Compare June 13, 2022 09:53
@HediBenFraj HediBenFraj changed the title console: prompting user to enter a valid jobid while executing run command with jobid argument [PR 1188] console: aborting job run if jobId doesn't exist in catalog. Jun 13, 2022
@HediBenFraj HediBenFraj force-pushed the dev/HediBenFraj/master/jobid-availabilty-check-exexcuting-run-command branch 2 times, most recently from 9e373fc to 9408d61 Compare June 20, 2022 09:43
@HediBenFraj HediBenFraj force-pushed the dev/HediBenFraj/master/jobid-availabilty-check-exexcuting-run-command branch 3 times, most recently from f69d770 to 4238563 Compare June 30, 2022 08:57
@HediBenFraj HediBenFraj force-pushed the dev/HediBenFraj/master/jobid-availabilty-check-exexcuting-run-command branch from 4238563 to 310cb84 Compare July 4, 2022 09:15
@HediBenFraj HediBenFraj force-pushed the dev/HediBenFraj/master/jobid-availabilty-check-exexcuting-run-command branch from 310cb84 to 85b986e Compare July 6, 2022 12:09
Copy link
Contributor

@alaaeddineelamri alaaeddineelamri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@joergsteffens joergsteffens merged commit 9b61bc6 into bareos:master Jul 7, 2022
bruno-at-bareos added a commit to bruno-at-bareos/bareos that referenced this pull request Jul 7, 2022
- Fix adding # in front of PR bareos#1198 and PR bareos#1188

Signed-off-by: Bruno Friedmann <bruno.friedmann@bareos.com>
bruno-at-bareos added a commit to bruno-at-bareos/bareos that referenced this pull request Jul 7, 2022
- Fix adding # in front of PR bareos#1198 and PR bareos#1188

Signed-off-by: Bruno Friedmann <bruno.friedmann@bareos.com>
bruno-at-bareos added a commit to bruno-at-bareos/bareos that referenced this pull request Jul 11, 2022
- Fix adding # in front of PR bareos#1198 and PR bareos#1188

Signed-off-by: Bruno Friedmann <bruno.friedmann@bareos.com>
bruno-at-bareos added a commit to bruno-at-bareos/bareos that referenced this pull request Jul 21, 2022
- Fix adding # in front of PR bareos#1188

Signed-off-by: Bruno Friedmann <bruno.friedmann@bareos.com>
bruno-at-bareos added a commit to bruno-at-bareos/bareos that referenced this pull request Jul 21, 2022
- Fix adding # in front of PR bareos#1188

Signed-off-by: Bruno Friedmann <bruno.friedmann@bareos.com>
bruno-at-bareos added a commit to bruno-at-bareos/bareos that referenced this pull request Aug 9, 2022
- Fix adding # in front of PR bareos#1188

Signed-off-by: Bruno Friedmann <bruno.friedmann@bareos.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants