Skip to content

Debian: fix Debian package dependencies for webui and Ceph#1183

Merged
joergsteffens merged 5 commits intomasterfrom
dev/joergs/master/ucs5
May 20, 2022
Merged

Debian: fix Debian package dependencies for webui and Ceph#1183
joergsteffens merged 5 commits intomasterfrom
dev/joergs/master/ucs5

Conversation

@joergsteffens
Copy link
Member

@joergsteffens joergsteffens commented May 18, 2022

Thank you for contributing to the Bareos Project!

Fixes some dependencies for bareos-webui on Debian based distributions
and also cleaning up a bit.
Required at least for installing Debian 10 packages on UCS 5.

Please check

  • Short description and the purpose of this PR is present above this paragraph
  • Your name is present in the AUTHORS file (optional)

If you have any questions or problems, please give a comment in the PR.

Helpful documentation and best practices

Checklist for the reviewer of the PR (will be processed by the Bareos team)

General
  • PR name is meaningful
  • Purpose of the PR is understood
  • Separate commit for this PR in the CHANGELOG.md, PR number referenced is same
  • Commit descriptions are understandable and well formatted
Source code quality
  • Source code changes are understandable
  • Variable and function names are meaningful
  • bareos-check-sources --since-merge does not report any problems
  • git status should not report modifications in the source tree after building and testing

libapache2-mod-php is now available on all supported Debian based distributions,
therefore we limit our dependencies to this package.
The php-* meta packages are also usable on all platforms.
joergsteffens added a commit that referenced this pull request May 18, 2022
@joergsteffens joergsteffens force-pushed the dev/joergs/master/ucs5 branch from 8223830 to 29a4cb5 Compare May 18, 2022 15:15
@joergsteffens joergsteffens requested a review from frb121 May 18, 2022 16:35
@joergsteffens joergsteffens marked this pull request as ready for review May 18, 2022 16:36
@joergsteffens joergsteffens changed the title webui: fix package dependencies webui: fix Debian package dependencies May 18, 2022
Copy link
Contributor

@frb121 frb121 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable and good to me.

Specify dependencies for Ubuntu 20.04 and 22.04.
Removing dependency for glusterfs-common,
as glusterfs related packages are currently not build
(as this would also require the package libglusterfs-dev)
joergsteffens added a commit that referenced this pull request May 19, 2022
@joergsteffens joergsteffens force-pushed the dev/joergs/master/ucs5 branch from 29a4cb5 to 59b5594 Compare May 19, 2022 19:45
@joergsteffens joergsteffens changed the title webui: fix Debian package dependencies Debian: fix Debian package dependencies for webui and Ceph May 19, 2022
@joergsteffens joergsteffens requested a review from frb121 May 19, 2022 19:46
Copy link
Contributor

@frb121 frb121 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@joergsteffens joergsteffens merged commit 16e6325 into master May 20, 2022
@joergsteffens joergsteffens deleted the dev/joergs/master/ucs5 branch May 20, 2022 09:32
bruno-at-bareos pushed a commit to tuxmaster5000/bareos that referenced this pull request Jul 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants