Skip to content

webui: fix uncaught TypeError if node.data is null#1096

Merged
pstorz merged 3 commits intobareos:bareos-21from
frb121:dev/fbergkemper/bareos-21/s5091
Mar 8, 2022
Merged

webui: fix uncaught TypeError if node.data is null#1096
pstorz merged 3 commits intobareos:bareos-21from
frb121:dev/fbergkemper/bareos-21/s5091

Conversation

@frb121
Copy link
Contributor

@frb121 frb121 commented Mar 3, 2022

Backport of PR #1087 to bareos-21

Thank you for contributing to the Bareos Project!

Please check

  • Short description and the purpose of this PR is present above this paragraph
  • Your name is present in the AUTHORS file (optional)

If you have any questions or problems, please give a comment in the PR.

Helpful documentation and best practices

Checklist for the reviewer of the PR (will be processed by the Bareos team)

General
  • PR name is meaningful
  • Purpose of the PR is understood
  • Separate commit for this PR in the CHANGELOG.md, PR number referenced is same
  • Commit descriptions are understandable and well formatted
  • If backport: add original PR number and target branch at top of this file: Backport of PR#000 to bareos-2x
Source code quality
  • Source code changes are understandable
  • Variable and function names are meaningful
  • Code comments are correct (logically and spelling)
  • Required documentation changes are present and part of the PR
  • bareos-check-sources --since-merge does not report any problems
  • git status should not report modifications in the source tree after building and testing
Tests
  • Decision taken that a system- or unittest is required (if not, then remove this paragraph)
  • The decision towards a systemtest is reasonable compared to a unittest
  • Testname matches exactly what is being tested
  • Output of the test leads quickly to the origin of the fault

@frb121 frb121 self-assigned this Mar 3, 2022
@frb121 frb121 requested a review from pstorz March 3, 2022 11:35
@frb121 frb121 changed the title Dev/fbergkemper/bareos 21/s5091 webui: fix uncaught TypeError if node.data is null Mar 3, 2022
@frb121 frb121 requested a review from bruno-at-bareos March 7, 2022 10:35
@pstorz pstorz merged commit 6861aec into bareos:bareos-21 Mar 8, 2022
pstorz pushed a commit to pstorz/bareos that referenced this pull request Mar 24, 2022
The error message on login failure should give a hint
when you try to login with a console user having the
"TLS Enable = false" parameter not set.

Fixes bareos#1096: misleading error message
@frb121 frb121 deleted the dev/fbergkemper/bareos-21/s5091 branch April 21, 2023 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants