stored: enable labeling of tapes in devices even when autoselect = no#1065
Merged
arogge merged 5 commits intobareos:bareos-21from Feb 7, 2022
Conversation
added 5 commits
February 7, 2022 12:53
added the following checks to the `autochanger` systemtest: -Checking `label` command doesn't skip device when `autoselect = no` -Checking `release` command doesn't skip device when `autoselect = no` -Checking backups are not affected by newly added change -Checking tape backups do not use devices that have `autoselect = no` systemtest: updated systemtest (cherry picked from commit f1cd8bc)
(cherry picked from commit cf38136)
(cherry picked from commit a09ad51)
(cherry picked from commit 399a349)
arogge
approved these changes
Feb 7, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
(Backports PR #1021)
When devices are set with the option autoselect=no, labeling and releasing is not possible as the device is skipped in the search. This PR handles this issue by not accounting for the autoselect attribute when searching devices. This has the same effect on the mount, unmount, as well as readlabel and autochanger commands. Backups are not affected.
Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
General
Source code quality
bareos-check-sources --since-mergedoes not report any problemsgit statusshould not report modifications in the source tree after building and testingTests