Skip to content

stored: enable labeling of tapes in devices even when autoselect = no#1065

Merged
arogge merged 5 commits intobareos:bareos-21from
alaaeddineelamri:dev/alaaeddineelamri/bareos-21/cannot-release-label-when-autoselect-no
Feb 7, 2022
Merged

stored: enable labeling of tapes in devices even when autoselect = no#1065
arogge merged 5 commits intobareos:bareos-21from
alaaeddineelamri:dev/alaaeddineelamri/bareos-21/cannot-release-label-when-autoselect-no

Conversation

@alaaeddineelamri
Copy link
Contributor

@alaaeddineelamri alaaeddineelamri commented Feb 7, 2022

Description

(Backports PR #1021)
When devices are set with the option autoselect=no, labeling and releasing is not possible as the device is skipped in the search. This PR handles this issue by not accounting for the autoselect attribute when searching devices. This has the same effect on the mount, unmount, as well as readlabel and autochanger commands. Backups are not affected.

Please check

  • Short description and the purpose of this PR is present above this paragraph
  • Your name is present in the AUTHORS file (optional)

If you have any questions or problems, please give a comment in the PR.

Helpful documentation and best practices

Checklist for the reviewer of the PR (will be processed by the Bareos team)

General
  • PR name is meaningful
  • Purpose of the PR is understood
  • Separate commit for this PR in the CHANGELOG.md, PR number referenced is same
  • Commit descriptions are understandable and well formatted
Source code quality
  • Source code changes are understandable
  • Variable and function names are meaningful
  • Code comments are correct (logically and spelling)
  • Required documentation changes are present and part of the PR
  • bareos-check-sources --since-merge does not report any problems
  • git status should not report modifications in the source tree after building and testing
Tests
  • Decision taken that a system- or unittest is required (if not, then remove this paragraph)
  • The decision towards a systemtest is reasonable compared to a unittest
  • Testname matches exactly what is being tested
  • Output of the test leads quickly to the origin of the fault

Alaa Eddine Elamri added 5 commits February 7, 2022 12:53
added the following checks to the `autochanger` systemtest:
-Checking `label` command doesn't skip device when `autoselect = no`
-Checking `release` command doesn't skip device when `autoselect = no`
-Checking backups are not affected by newly added change
-Checking tape backups do not use devices that have `autoselect = no`
systemtest: updated systemtest

(cherry picked from commit f1cd8bc)
(cherry picked from commit 399a349)
@arogge arogge merged commit 21e2404 into bareos:bareos-21 Feb 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants