stored: enable labeling of tapes in devices even when autoselect = no#1021
Merged
arogge merged 5 commits intobareos:masterfrom Feb 7, 2022
Conversation
release or label when autoselect = norelease and label on devices where autoselect = no
pstorz
reviewed
Dec 10, 2021
release and label on devices where autoselect = noautoselect = no
pstorz
previously requested changes
Dec 10, 2021
Member
pstorz
left a comment
There was a problem hiding this comment.
Excellent work!
It might make sense to refactor this test to have setup and teardown, and to have two autochanger tests (the original one and the new one testing the label functionality)
bd336ae to
c11ef92
Compare
c11ef92 to
6acc04f
Compare
arogge
reviewed
Jan 17, 2022
Member
arogge
left a comment
There was a problem hiding this comment.
This looks like a good idea, I just wouldn't return a device with autoselect = no unless the caller explicitly asks for that one.
48f81f6 to
917a9b9
Compare
arogge
requested changes
Jan 24, 2022
systemtests/tests/autochanger/testrunner-label-release-autoselect
Outdated
Show resolved
Hide resolved
9da8672 to
dccbf0c
Compare
arogge
requested changes
Feb 4, 2022
Member
arogge
left a comment
There was a problem hiding this comment.
bareos-check-sources is not happy yet.
Other than that, it looks great and can be merged.
added 5 commits
February 4, 2022 15:02
added the following checks to the `autochanger` systemtest: -Checking `label` command doesn't skip device when `autoselect = no` -Checking `release` command doesn't skip device when `autoselect = no` -Checking backups are not affected by newly added change -Checking tape backups do not use devices that have `autoselect = no` systemtest: updated systemtest
dccbf0c to
399a349
Compare
arogge
approved these changes
Feb 7, 2022
11 tasks
16 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
When devices are set with the option
autoselect=no, labeling and releasing is not possible as the device is skipped in the search. This PR handles this issue by not accounting for theautoselectattribute when searching devices. This has the same effect on themount,unmount, as well asreadlabelandautochangercommands. Backups are not affected.Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
General
Source code quality
bareos-check-sources --since-mergedoes not report any problemsgit statusshould not report modifications in the source tree after building and testingTests