Python plugins: add default module_path to search path#1038
Merged
Conversation
5e122ff to
edcf6e4
Compare
d153f3c to
1b0b509
Compare
1b0b509 to
99ed130
Compare
joergsteffens
added a commit
that referenced
this pull request
Jan 20, 2022
pstorz
reviewed
Jan 26, 2022
Member
pstorz
left a comment
There was a problem hiding this comment.
Checked first commit and the changes look good to me.
Good work!
sduehr
requested changes
Jan 28, 2022
Member
sduehr
left a comment
There was a problem hiding this comment.
Thanks a lot, only found some typos.
...c/plugins/filed/python/ldap/python-ldap-conf.d/bareos-dir.d/fileset/plugin-ldap.conf.example
Outdated
Show resolved
Hide resolved
docs/manuals/source/TasksAndConcepts/Plugins/DirectorPlugins/PythonDirPlugin.rst.inc
Outdated
Show resolved
Hide resolved
docs/manuals/source/TasksAndConcepts/Plugins/DirectorPlugins/PythonDirPlugin.rst.inc
Outdated
Show resolved
Hide resolved
docs/manuals/source/TasksAndConcepts/Plugins/FileDaemonPlugins/PythonFdPlugin.rst.inc
Outdated
Show resolved
Hide resolved
Use PYTHON_MODULE_PATH as default Python module search path for Python plugins. Also use identical "PyLoadModule" function for all daemons. Before all 3 python plugins did use there own version of the PyLoadModule function.
Co-authored-by: sduehr <stephan.duehr@bareos.com>
Only keep general information about Python Plugins in the "Tasks and Concepts" chapter, moving the implentation details to the Development Guide chapter. Change the ordering in the Developement chapter to start with the current version of the Python Plugin: * Python Plugins for Bareos >= 20 * Python Plugins for Bareos < 20 * Migrating Python Plugins to Bareos >= 20
Co-authored-by: sduehr <stephan.duehr@bareos.com>
689a586 to
6e128f6
Compare
Member
Author
|
@sduehr thank you for your suggestions. I've applied them and then rebased them on master, because of a merge conflict. It would be great, if you can review this PR again. Also 5 check-marks are not set. Do you request changes from my side? |
Member
Author
|
As discussed: not version change required. |
12 tasks
pstorz
pushed a commit
to arogge/bareos
that referenced
this pull request
Apr 26, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently all Python modules get installed to the plugin directory.
However, every plugin configuration requires the parameter module_path set to this value.
This PR adds the Python Plugin module path to the default search path, so that specifying the module_path is only unnecessary in non-standard installations.
OP#5043
Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
General
Source code quality
bareos-check-sources --since-mergedoes not report any problemsgit statusshould not report modifications in the source tree after building and testing