Skip to content

add MariaDB#226

Merged
dfranco merged 1 commit intobacula-web:masterfrom
robertsilen:master
Aug 8, 2024
Merged

add MariaDB#226
dfranco merged 1 commit intobacula-web:masterfrom
robertsilen:master

Conversation

@robertsilen
Copy link
Copy Markdown
Contributor

Suggesting MariaDB to be added to README as discussed in discussions/225. MariaDB is also now mentioned as compatible on PHP MySQL Driver and Plugins that the README links to - as of /php/doc-en/pull/3639.

@dfranco
Copy link
Copy Markdown
Member

dfranco commented Aug 6, 2024

@robertsilen
Copy link
Copy Markdown
Contributor Author

Please use conventional commits

See https://docs.bacula-web.org/en/latest/04_contribute/development.html#guidance-for-developers

Thank you for instructions. I believe I follow these, or do you want me to open a bug issue in addition to the original #224 that became a discussion #225?

@dfranco
Copy link
Copy Markdown
Member

dfranco commented Aug 7, 2024

Please use conventional commits

See https://docs.bacula-web.org/en/latest/04_contribute/development.html#guidance-for-developers

Thank you for instructions. I believe I follow these, or do you want me to open a bug issue in addition to the original #224 that became a discussion #225?

Hi @robertsilen,

No need to create another issue, but you need to amend the commit you've made on your branch.

The commit message should look more like below

fix(docs): missing mariadb support

Add missing support for MariaDB.

If you don't know how to amend a git commit, don't hesitate to ask for help here.

Thanks for your contribution by the way

Best,

Add missing support for MariaDB.
@robertsilen
Copy link
Copy Markdown
Contributor Author

Thanks @dfranco, I ran git commit --amend, edited the commit message, and then git push --force. Hope it is ok now.

@dfranco dfranco merged commit c1e9597 into bacula-web:master Aug 8, 2024
dfranco pushed a commit that referenced this pull request Sep 29, 2024
Add missing support for MariaDB.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants