Support CHECK CONSTRAINTS options and Fix Error aborting Cycle in TSQL Bulk Copy#2596
Merged
KushaalShroff merged 7 commits intobabelfish-for-postgresql:BABEL_4_X_DEVfrom May 23, 2024
Conversation
7ec68e4 to
a22e960
Compare
a22e960 to
063f4e3
Compare
This reverts commit 063f4e3.
e68230e to
c71ac41
Compare
Collaborator
Pull Request Test Coverage Report for Build 9199093451Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
lejaokri
reviewed
May 22, 2024
lejaokri
approved these changes
May 22, 2024
KushaalShroff
added a commit
to amazon-aurora/babelfish_extensions
that referenced
this pull request
May 28, 2024
…L Bulk Copy (babelfish-for-postgresql#2596) This commit has the following changes: 1. Fix Permissions checking missed in d95b7ad 2. Fix the error handling behaviour in Bulk Copy. While processing a batch of inserts, if there are unexpected errors then the current design aborts the insert and later tries to cleanup the stale buffers. During cleanup we were not checking for aborted phase and thus flushing buffers even when we didnt have to. With this commit we fix this by not flushing during cleanup in the abort phase. 3. Also supported CHECK_CONSTRAINTS insert bulk options with this commit. The ideal behaviour is to not check any constraints unless user passes the CHECK_CONSTRAINTS options. We have now implemented the same for Babelfish. Issues Resolved BABEL-4200, BABEL-4991 Authored-by: Kushaal Shroff kushaal@amazon.com Signed-off-by: Kushaal Shroff kushaal@amazon.com
KushaalShroff
added a commit
to amazon-aurora/babelfish_extensions
that referenced
this pull request
May 28, 2024
…L Bulk Copy (babelfish-for-postgresql#2596) This commit has the following changes: 1. Fix Permissions checking missed in d95b7ad 2. Fix the error handling behaviour in Bulk Copy. While processing a batch of inserts, if there are unexpected errors then the current design aborts the insert and later tries to cleanup the stale buffers. During cleanup we were not checking for aborted phase and thus flushing buffers even when we didnt have to. With this commit we fix this by not flushing during cleanup in the abort phase. 3. Also supported CHECK_CONSTRAINTS insert bulk options with this commit. The ideal behaviour is to not check any constraints unless user passes the CHECK_CONSTRAINTS options. We have now implemented the same for Babelfish. Issues Resolved BABEL-4200, BABEL-4991 Authored-by: Kushaal Shroff kushaal@amazon.com Signed-off-by: Kushaal Shroff kushaal@amazon.com
KushaalShroff
added a commit
to amazon-aurora/babelfish_extensions
that referenced
this pull request
May 29, 2024
…L Bulk Copy (babelfish-for-postgresql#2596) This commit has the following changes: 1. Fix Permissions checking missed in d95b7ad 2. Fix the error handling behaviour in Bulk Copy. While processing a batch of inserts, if there are unexpected errors then the current design aborts the insert and later tries to cleanup the stale buffers. During cleanup we were not checking for aborted phase and thus flushing buffers even when we didnt have to. With this commit we fix this by not flushing during cleanup in the abort phase. 3. Also supported CHECK_CONSTRAINTS insert bulk options with this commit. The ideal behaviour is to not check any constraints unless user passes the CHECK_CONSTRAINTS options. We have now implemented the same for Babelfish. Issues Resolved BABEL-4200, BABEL-4991 Authored-by: Kushaal Shroff kushaal@amazon.com Signed-off-by: Kushaal Shroff kushaal@amazon.com
KushaalShroff
added a commit
to amazon-aurora/babelfish_extensions
that referenced
this pull request
May 29, 2024
…L Bulk Copy (babelfish-for-postgresql#2596) This commit has the following changes: 1. Fix Permissions checking missed in d95b7ad 2. Fix the error handling behaviour in Bulk Copy. While processing a batch of inserts, if there are unexpected errors then the current design aborts the insert and later tries to cleanup the stale buffers. During cleanup we were not checking for aborted phase and thus flushing buffers even when we didnt have to. With this commit we fix this by not flushing during cleanup in the abort phase. 3. Also supported CHECK_CONSTRAINTS insert bulk options with this commit. The ideal behaviour is to not check any constraints unless user passes the CHECK_CONSTRAINTS options. We have now implemented the same for Babelfish. Issues Resolved BABEL-4200, BABEL-4991 Authored-by: Kushaal Shroff kushaal@amazon.com Signed-off-by: Kushaal Shroff kushaal@amazon.com
KushaalShroff
added a commit
to amazon-aurora/babelfish_extensions
that referenced
this pull request
May 29, 2024
…L Bulk Copy (babelfish-for-postgresql#2596) This commit has the following changes: 1. Fix Permissions checking missed in d95b7ad 2. Fix the error handling behaviour in Bulk Copy. While processing a batch of inserts, if there are unexpected errors then the current design aborts the insert and later tries to cleanup the stale buffers. During cleanup we were not checking for aborted phase and thus flushing buffers even when we didnt have to. With this commit we fix this by not flushing during cleanup in the abort phase. 3. Also supported CHECK_CONSTRAINTS insert bulk options with this commit. The ideal behaviour is to not check any constraints unless user passes the CHECK_CONSTRAINTS options. We have now implemented the same for Babelfish. Issues Resolved BABEL-4200, BABEL-4991 Authored-by: Kushaal Shroff kushaal@amazon.com Signed-off-by: Kushaal Shroff kushaal@amazon.com
KushaalShroff
added a commit
to amazon-aurora/babelfish_extensions
that referenced
this pull request
May 29, 2024
…L Bulk Copy (babelfish-for-postgresql#2596) This commit has the following changes: 1. Fix Permissions checking missed in d95b7ad 2. Fix the error handling behaviour in Bulk Copy. While processing a batch of inserts, if there are unexpected errors then the current design aborts the insert and later tries to cleanup the stale buffers. During cleanup we were not checking for aborted phase and thus flushing buffers even when we didnt have to. With this commit we fix this by not flushing during cleanup in the abort phase. 3. Also supported CHECK_CONSTRAINTS insert bulk options with this commit. The ideal behaviour is to not check any constraints unless user passes the CHECK_CONSTRAINTS options. We have now implemented the same for Babelfish. Issues Resolved BABEL-4200, BABEL-4991 Authored-by: Kushaal Shroff kushaal@amazon.com Signed-off-by: Kushaal Shroff kushaal@amazon.com
KushaalShroff
added a commit
to amazon-aurora/babelfish_extensions
that referenced
this pull request
Jun 27, 2024
…L Bulk Copy (babelfish-for-postgresql#2596) This commit has the following changes: 1. Fix Permissions checking missed in d95b7ad 2. Fix the error handling behaviour in Bulk Copy. While processing a batch of inserts, if there are unexpected errors then the current design aborts the insert and later tries to cleanup the stale buffers. During cleanup we were not checking for aborted phase and thus flushing buffers even when we didnt have to. With this commit we fix this by not flushing during cleanup in the abort phase. 3. Also supported CHECK_CONSTRAINTS insert bulk options with this commit. The ideal behaviour is to not check any constraints unless user passes the CHECK_CONSTRAINTS options. We have now implemented the same for Babelfish. Issues Resolved BABEL-4200, BABEL-4991 Authored-by: Kushaal Shroff kushaal@amazon.com Signed-off-by: Kushaal Shroff kushaal@amazon.com
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This commit has the following changes:
Authored-by: Kushaal Shroff kushaal@amazon.com
Signed-off-by: Kushaal Shroff kushaal@amazon.com
Issues Resolved
BABEL-4200, BABEL-4991
Test Scenarios Covered
Use case based -
Yes
Boundary conditions -
Yes
Arbitrary inputs -
Negative test cases -
Minor version upgrade tests -
Major version upgrade tests -
Performance tests -
Tooling impact -
Client tests -
Check List
By submitting this pull request, I confirm that my contribution is under the terms of the Apache 2.0 and PostgreSQL licenses, and grant any person obtaining a copy of the contribution permission to relicense all or a portion of my contribution to the PostgreSQL License solely to contribute all or a portion of my contribution to the PostgreSQL open source project.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.