docs: add noIncompleteNsImportDetection assumption#2545
Merged
nicolo-ribaudo merged 2 commits intobabel:mainfrom Aug 4, 2021
Merged
docs: add noIncompleteNsImportDetection assumption#2545nicolo-ribaudo merged 2 commits intobabel:mainfrom
noIncompleteNsImportDetection assumption#2545nicolo-ribaudo merged 2 commits intobabel:mainfrom
Conversation
|
✔️ Deploy Preview for babel ready! 🔨 Explore the source changes: bb886b7 🔍 Inspect the deploy log: https://app.netlify.com/sites/babel/deploys/610afa328358370008cd61e6 😎 Browse the preview: https://deploy-preview-2545--babel.netlify.app |
existentialism
approved these changes
Jun 21, 2021
JLHwung
reviewed
Aug 3, 2021
Contributor
There was a problem hiding this comment.
Can you also add an assumption section (can refer to here) in https://babeljs.io/docs/en/babel-plugin-transform-modules-commonjs ? So the assumptions option earn more visibility when people are reading plugin docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add docs for changes in babel/babel#13290