Skip to content

Add assumptions to repl UI#2539

Merged
JLHwung merged 4 commits intobabel:mainfrom
AjayPoshak:add-assumptions
Jul 30, 2021
Merged

Add assumptions to repl UI#2539
JLHwung merged 4 commits intobabel:mainfrom
AjayPoshak:add-assumptions

Conversation

@AjayPoshak
Copy link
Copy Markdown
Contributor

@AjayPoshak AjayPoshak commented May 22, 2021 •
edited by nicolo-ribaudo
Loading

@AjayPoshak AjayPoshak changed the title Add assumptions in UI Add assumptions to repl UI May 22, 2021
@netlify
Copy link
Copy Markdown

netlify bot commented May 22, 2021 •
edited
Loading

✔️ Deploy Preview for babel ready!
Built without sensitive environment variables

🔨 Explore the source changes: 14277ff

🔍 Inspect the deploy log: https://app.netlify.com/sites/babel/deploys/60d1e07294e2230008a355b7

😎 Browse the preview: https://deploy-preview-2539--babel.netlify.app

JLHwung
JLHwung reviewed May 27, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@JLHwung JLHwung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The assumptions should also be persisted to the URL. For example, when a user clicks the assumption iterableIsArray and then copies the REPL URL, one will expect that if another person clicks this link, iterableIsArray will be enabled.

@AjayPoshak
Copy link
Copy Markdown
Contributor Author

AjayPoshak commented Jun 4, 2021

The assumptions should also be persisted to the URL. For example, when a user clicks the assumption iterableIsArray and then copies the REPL URL, one will expect that if another person clicks this link, iterableIsArray will be enabled.

done

@AjayPoshak AjayPoshak requested a review from JLHwung June 4, 2021 14:37
@AjayPoshak
Copy link
Copy Markdown
Contributor Author

AjayPoshak commented Jun 21, 2021

@JLHwung Please review.

@fedeci fedeci self-requested a review June 21, 2021 09:21
@nicolo-ribaudo
Copy link
Copy Markdown
Member

nicolo-ribaudo commented Jun 21, 2021

I tested the repl, and it looks like when I change an assumption the code is not re-compiled? Ideally they should trigger a recompilation with the new config.

JLHwung
JLHwung reviewed Jun 21, 2021
View reviewed changes
@AjayPoshak
Copy link
Copy Markdown
Contributor Author

AjayPoshak commented Jun 22, 2021

I tested the repl, and it looks like when I change an assumption the code is not re-compiled? Ideally they should trigger a recompilation with the new config.

fixed

@AjayPoshak AjayPoshak requested a review from JLHwung June 22, 2021 13:17
JLHwung
JLHwung approved these changes Jun 22, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@JLHwung JLHwung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

fedeci
fedeci reviewed Jun 24, 2021
View reviewed changes
@JLHwung JLHwung merged commit 06693d6 into babel:main Jul 30, 2021
@AjayPoshak AjayPoshak deleted the add-assumptions branch August 2, 2021 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JLHwung JLHwung JLHwung approved these changes

@fedeci fedeci fedeci approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add assumptions to repl

4 participants

@AjayPoshak @nicolo-ribaudo @JLHwung @fedeci