[static private] Use explicit descriptors instead of an object#8620
Merged
nicolo-ribaudo merged 2 commits intobabel:masterfrom Sep 5, 2018
Merged
Conversation
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/9016/ |
b2736c1 to
0f2ed66
Compare
jridgewell
approved these changes
Sep 4, 2018
This is similar to ec69b4b, which was about private instance fields. Private properties can be non-writable (thanks to decorators), or have get/set accessors. If we stored this information on the `privateClass` object, we would need to always use `Object.getOwnPropertyDescriptor` before reading or writing a property because accessors need to be called with the correct `this` context (it should be the actual class, not the object hat stores the private properties). This commit simplifies that operation a bit by removing the container object. It also have another advantage, which instance fields already have thanks to the use of separate weakmaps: unused private static fields can be tree-shaken away or garbage-collected, while properties of an object can't. Also, they can be easilier minified.
0f2ed66 to
1f974e9
Compare
Member
Author
|
I'm going to merge this so I can rebase #8130 to check that everything still works. |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This isn't strictly required, but it makes the transform a little bit simpler.
cc @rricard @jridgewell