Save full descriptor instead of only value for private fields.#8318
Merged
hzoo merged 3 commits intobabel:masterfrom Jul 27, 2018
Merged
Save full descriptor instead of only value for private fields.#8318hzoo merged 3 commits intobabel:masterfrom
hzoo merged 3 commits intobabel:masterfrom
Conversation
Decorators can make private fields non-writable, so we need to store this information smewhere. The descriptor can also be used to implement private accessors.
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/8604/ |
jridgewell
reviewed
Jul 27, 2018
| MAP.set(REF, { | ||
| // configurable is always false for private elements | ||
| // enumerable is always false for private elements | ||
| writable: true, |
Member
There was a problem hiding this comment.
We can save bytes be doing an explicit check for === false. Then, we don't have to always include the writable: true.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1, Fixes #2Decorators can make private fields non-writable, so we need to store this information smewhere.
The descriptor can also be used to implement private accessors.
This patch isn't needed for loose mose because we already use
definePropertywith a property descriptor.