Make .insert{Before,After} work by default when the parent is an eport declaration#7040
Merged
nicolo-ribaudo merged 4 commits intobabel:masterfrom Dec 18, 2017
Merged
Conversation
It makes the output of insertAfter a bit nicer:
In:
export default 2;
Out (Before):
var _temp;
export default (_temp = 2, x, _temp)
Out (Now):
export default 2;
x
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/6215/ |
existentialism
approved these changes
Dec 18, 2017
hzoo
approved these changes
Dec 18, 2017
nicolo-ribaudo
added a commit
to nicolo-ribaudo/babel
that referenced
this pull request
Dec 27, 2017
nicolo-ribaudo
added a commit
that referenced
this pull request
Dec 28, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes
declarationPath.insertBefore()anddeclarationPath.insertAfter()work by default even ifdeclarationPath.parentPath.isExportDeclaration().Babel already handles it in a similar way when
path.parentPath.isLabelledStatement(): https://astexplorer.net/#/gist/192e79a63708ad6195496dffe34b6fd7/35538c7478fe1340c9e8bdb2e6c40f24f5adc40bAs you can see by the diff, we already had to handle insertion before/after exported declarations in different places. Less special cases to think about -> less probability of forgetting about them.
This PR doesn't introduce breaking changes, because it only makes cases that previously threw do what it is actually expected.