Skip to content

add individual polyfill files#5584

Merged
hzoo merged 3 commits into7.0from
polyfill-files
Apr 5, 2017
Merged

add individual polyfill files#5584
hzoo merged 3 commits into7.0from
polyfill-files

Conversation

@hzoo
Copy link
Copy Markdown
Member

@hzoo hzoo commented Apr 4, 2017 •
edited
Loading

It's weird to have the transform for babel-preset-env useBuiltIns change the require

In

import "babel-polyfill";

Out (current)

import "core-js/modules/es7.string.pad-start";
import "core-js/modules/es7.string.pad-end";

With this we can change it to be something like

import "babel-polyfill/core-js/modules/es7.string.pad-end";
import "babel-polyfill/regenerator-runtime/runtime";

Which just appends the path to babel-polyfill

import "babel-polyfill/es7.string.pad-start";
import "babel-polyfill/es2016.string.pad-start"; // or
import "babel-polyfill/string.pad-start"; // or
otherwise just recommend using core-js directly and transforming that.

hzoo added a commit to babel/babel-preset-env that referenced this pull request Apr 4, 2017
@hzoo
Breaking: account for babel/babel#5584, only run on babel-polyfill no…
9f754cf 
…t core-js

return babel-polyfill require instead of core-js
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 5, 2017 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (7.0@7ad697c). Click here to learn what that means.
The diff coverage is 0%.

Impacted file tree graph

@@          Coverage Diff           @@
##             7.0    #5584   +/-   ##
======================================
  Coverage       ?   84.71%           
======================================
  Files          ?      287           
  Lines          ?     9598           
  Branches       ?     2704           
======================================
  Hits           ?     8131           
  Misses         ?      971           
  Partials       ?      496
Impacted Files Coverage Δ
...src/core-js/modules/es6.number.max-safe-integer.js 0% <0%> (ø)
...abel-polyfill/src/core-js/modules/es6.math.cbrt.js 0% <0%> (ø)
...bel-polyfill/src/core-js/modules/es6.array.find.js 0% <0%> (ø)
...yfill/src/core-js/modules/es6.number.is-integer.js 0% <0%> (ø)
...fill/src/core-js/modules/es6.typed.array-buffer.js 0% <0%> (ø)
...yfill/src/core-js/modules/es6.typed.int16-array.js 0% <0%> (ø)
...lyfill/src/core-js/modules/es6.number.is-finite.js 0% <0%> (ø)
...babel-polyfill/src/core-js/modules/es6.weak-map.js 0% <0%> (ø)
...-polyfill/src/core-js/modules/es6.function.name.js 0% <0%> (ø)
...-polyfill/src/core-js/modules/es6.object.assign.js 0% <0%> (ø)
... and 77 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ad697c...dbf075e. Read the comment docs.

@hzoo hzoo added the PR: New Feature 🚀 A type of pull request used for our changelog categories label Apr 5, 2017
@hzoo hzoo added this to the Babel 7 milestone Apr 5, 2017
@hzoo hzoo merged commit 8f848b4 into 7.0 Apr 5, 2017
@hzoo hzoo deleted the polyfill-files branch April 5, 2017 19:14
@hzoo hzoo mentioned this pull request Apr 7, 2017
Closed
@existentialism existentialism mentioned this pull request Jul 26, 2017
Closed
@existentialism existentialism mentioned this pull request Nov 6, 2017
Merged
@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 6, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@existentialism existentialism existentialism approved these changes

+1 more reviewer

@danez danez danez approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: New Feature 🚀 A type of pull request used for our changelog categories

Projects

None yet

Milestone

Babel 7 Beta

Development

Successfully merging this pull request may close these issues.

3 participants

@hzoo @existentialism @danez