Switch to nyc, babel-plugin-istanbul & codecov-node for code coverage #4885
Conversation
This setup (very much like Babylon's) let us trace code coverage back to the `src/` directories of packages.
|
Oh lovely. @bcoe I really appreciate you picking this up. |
Current coverage is 89.22% (diff: 100%)@@ master #4885 diff @@
==========================================
Files 196 204 +8
Lines 14022 10487 -3535
Methods 1460 1153 -307
Messages 0 0
Branches 3263 2762 -501
==========================================
- Hits 12529 9357 -3172
+ Misses 1493 1130 -363
Partials 0 0
|
Makefile
Outdated
| NODE_ENV=test make bootstrap | ||
| ./scripts/test-cov.sh | ||
| cat ./coverage/coverage.json | ./node_modules/codecov.io/bin/codecov.io.js | ||
| # if ./node_modules/.bin/semver `npm --version` -r ">=3.3.0"; then ./node_modules/.bin/flow check; fi |
There was a problem hiding this comment.
this comment can be removed since we run flow in a separate travis thing now
|
@hzoo 👍 |
|
Dono if it's worth adding make/npm command for us to open the coverage locally (if it works online then great, since it always seemed to be weird for me) |
|
@hzoo you can run:
And view an html report in the |
|
@hzoo perhaps we can land this, and in a separate issue if you describe to me the types of reports you'd like output I'd be happy to add a few more npm-scripts for you post-hoc. |
|
Ah yeah that was just a comment not a review or anything (I wasn't doing much oss last week) |
…babel#4885) * Switch to nyc, babel-plugin-istanbul & codecov-node for code coverage This setup (very much like Babylon's) let us trace code coverage back to the `src/` directories of packages. * Exclude package tests from coverage report * fix: upgrade to version of nyc that tweaks a couple more things for babel * fix: remove comment based on @hzoo's review
This sees @motiz88's work over the finish line; I released a couple more changes to nyc for babel's benefit (caching on by default, configurable debug output) and tested thoroughly:
See #4740Just a couple tweaks to @motiz88's work, and a rebase with master; would love to see this over the finish line:
Note: we do now add empty reports for files that aren't accessed.
CC: @danez, @hzoo