Fix tests with duplicate named exports#4538
Merged
danez merged 6 commits intobabel:masterfrom Sep 21, 2016
Merged
Conversation
added 6 commits
September 20, 2016 23:51
Current coverage is 88.34% (diff: 100%)@@ master #4538 diff @@
==========================================
Files 194 194
Lines 13621 13621
Methods 1427 1427
Messages 0 0
Branches 3150 3150
==========================================
Hits 12033 12033
Misses 1588 1588
Partials 0 0
|
danez
approved these changes
Sep 21, 2016
Member
danez
left a comment
There was a problem hiding this comment.
Thank you. Wasn't aware that it is that much changes. Really appreciate it.
Member
|
Thanks @kaicataldo! nice work |
panagosg7
pushed a commit
to panagosg7/babel
that referenced
this pull request
Jan 17, 2017
* Fix babel-plugin-transform-flow-strip-types tests * Fix babel-plugin-transform-es2015-modules-umd tests * Fix babel-generator tests * Fix babel-plugin-transform-es2015-modules-systemjs tests * Fix babel-plugin-transform-es2015-modules-commonjs tests * Fix babel-plugin-transform-es2015-modules-amd tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixing the tests to allow for the following babylon PR that throws on duplicate exports to land.
I will also make a 2nd PR removing the band-aid fix implemented in this PR as well as renaming the test files I created to follow the convention used in this PR. Coming up with unique test file names doesn't make a lot of sense since they were all in one file previously - numbering them has the same effect with less cognitive if and when more need to be added.