Refactor traversal to avoid closures for perf#433
Merged
sebmck merged 1 commit intobabel:masterfrom Jan 10, 2015
Merged
Conversation
33bf036 to
32ec805
Compare
Member
Author
|
Nevermind. Doesn't help at all so let's stick with this for now. |
This was referenced Jan 9, 2015
Contributor
|
@gaearon This looks really good. The traversal stuff really needed a refactor but I haven't gotten around to it. Can you do a rebase so I can merge? |
32ec805 to
a4e6da2
Compare
a4e6da2 to
421906b
Compare
Member
Author
|
Done! |
sebmck
added a commit
that referenced
this pull request
Jan 10, 2015
Refactor traversal to avoid closures for perf
Contributor
|
Thanks! |
Member
Author
|
Thanks for quick merge! |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit completely removes closures from the hottest method ever,
traverse.Combined with #432, this gives 38% improvement over master (130 ms vs 212 ms on my benchmark).
Alone, this gives 24% improvement over master (162 ms).